From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CA0C28CC5 for ; Sat, 8 Jun 2019 10:31:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C32C7214DA for ; Sat, 8 Jun 2019 10:31:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="aI8Qzaak" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726859AbfFHKbI (ORCPT ); Sat, 8 Jun 2019 06:31:08 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:60816 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbfFHKbI (ORCPT ); Sat, 8 Jun 2019 06:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1559989866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mjUlMAfq0xB1yqTJJJZKG9pZnAqTQaYVUiyezB1q1UQ=; b=aI8QzaakpPRpb0PGEhibv4Pb8bb4V5fAmJlFMM0vaHkZ9d+sHJDhI3BSecbG0r7TxZdTDW 2GABj9M8K6aCfH67SSc/oypLI235h1h1O59x/LiJBr/LO1LVi4v8fgHnieO3Zp1FgDVAQu ablMqrked8DNPfL0/Z6VVp6LMsvBfUs= Date: Sat, 08 Jun 2019 12:31:01 +0200 From: Paul Cercueil Subject: Re: [PATCH v2 6/6] pwm: jz4740: Use __init_or_module and __exit for .probe and .remove To: Thierry Reding , Rob Herring , Mark Rutland Cc: od@zcrc.me, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <1559989861.1815.10@crapouillou.net> In-Reply-To: <20190607154410.10633-7-paul@crapouillou.net> References: <20190607154410.10633-1-paul@crapouillou.net> <20190607154410.10633-7-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I misunderstood what __init_or_module was for. Please ignore this patch (the rest of the patchset is OK). Sorry for the noise. Le ven. 7 juin 2019 =E0 17:44, Paul Cercueil a=20 =E9crit : > This allows the probe function to be dropped after the kernel finished > its initialization, in the case where the driver was not compiled as a > module. >=20 > Signed-off-by: Paul Cercueil > --- >=20 > Notes: > v2: New patch >=20 > drivers/pwm/pwm-jz4740.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c > index f901e8a0d33d..1b5077825721 100644 > --- a/drivers/pwm/pwm-jz4740.c > +++ b/drivers/pwm/pwm-jz4740.c > @@ -145,7 +145,7 @@ static const struct pwm_ops jz4740_pwm_ops =3D { > .owner =3D THIS_MODULE, > }; >=20 > -static int jz4740_pwm_probe(struct platform_device *pdev) > +static int __init_or_module jz4740_pwm_probe(struct platform_device=20 > *pdev) > { > struct jz4740_pwm_chip *jz4740; >=20 > @@ -169,7 +169,7 @@ static int jz4740_pwm_probe(struct=20 > platform_device *pdev) > return pwmchip_add(&jz4740->chip); > } >=20 > -static int jz4740_pwm_remove(struct platform_device *pdev) > +static int __exit jz4740_pwm_remove(struct platform_device *pdev) > { > struct jz4740_pwm_chip *jz4740 =3D platform_get_drvdata(pdev); >=20 > -- > 2.21.0.593.g511ec345e18 >=20 =