From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v4 0/7] perf diff: diff cycles at basic block level
Date: Thu, 20 Jun 2019 22:36:35 +0800 [thread overview]
Message-ID: <1561041402-29444-1-git-send-email-yao.jin@linux.intel.com> (raw)
In some cases small changes in hot loops can show big differences.
But it's difficult to identify these differences.
perf diff currently can only diff symbols (functions). We can also expand
it to diff cycles of individual programs blocks as reported by timed LBR.
This would allow to identify changes in specific code accurately.
With this patch set, for example,
$ perf record -b ./div
$ perf record -b ./div
$ perf diff -c cycles
# Event 'cycles'
#
# Baseline [Program Block Range] Cycles Diff Shared Object Symbol
# ........ ...................................................................... ................ ..................................
#
48.75% [div.c:42 -> div.c:45] 147 div [.] main
48.75% [div.c:31 -> div.c:40] 4 div [.] main
48.75% [div.c:40 -> div.c:40] 0 div [.] main
48.75% [div.c:42 -> div.c:42] 0 div [.] main
48.75% [div.c:42 -> div.c:44] 0 div [.] main
19.02% [random_r.c:357 -> random_r.c:360] 0 libc-2.23.so [.] __random_r
19.02% [random_r.c:357 -> random_r.c:373] 0 libc-2.23.so [.] __random_r
19.02% [random_r.c:357 -> random_r.c:376] 0 libc-2.23.so [.] __random_r
19.02% [random_r.c:357 -> random_r.c:380] 0 libc-2.23.so [.] __random_r
19.02% [random_r.c:357 -> random_r.c:392] 0 libc-2.23.so [.] __random_r
16.17% [random.c:288 -> random.c:291] 0 libc-2.23.so [.] __random
16.17% [random.c:288 -> random.c:291] 0 libc-2.23.so [.] __random
16.17% [random.c:288 -> random.c:295] 0 libc-2.23.so [.] __random
16.17% [random.c:288 -> random.c:297] 0 libc-2.23.so [.] __random
16.17% [random.c:291 -> random.c:291] 0 libc-2.23.so [.] __random
16.17% [random.c:293 -> random.c:293] 0 libc-2.23.so [.] __random
8.21% [div.c:22 -> div.c:22] 148 div [.] compute_flag
8.21% [div.c:22 -> div.c:25] 0 div [.] compute_flag
8.21% [div.c:27 -> div.c:28] 0 div [.] compute_flag
5.52% [rand.c:26 -> rand.c:27] 0 libc-2.23.so [.] rand
5.52% [rand.c:26 -> rand.c:28] 0 libc-2.23.so [.] rand
2.27% [rand@plt+0 -> rand@plt+0] 0 div [.] rand@plt
0.01% [entry_64.S:694 -> entry_64.S:694] 16 [kernel.vmlinux] [k] native_irq_return_iret
0.00% [fair.c:7676 -> fair.c:7665] 162 [kernel.vmlinux] [k] update_blocked_averages
'[Program Block Range]' indicates the range of program basic block
(start -> end). If we can find the source line it prints the source
line otherwise it prints the symbol+offset instead.
v4:
---
Use source lines or symbol+offset to indicate the basic block.
Changed patches:
perf diff: Print the basic block cycles diff
perf diff: Documentation -c cycles option
v3:
---
In v3, the major change is to move most of block stuffs from
'struct hist_entry' to new structure 'struct block_hist' and
update the code accordingly. But we still have to keep the
block_info in 'struct hist_entry' since we need to compare by
block info when inserting new entry to hists.
Others are minor changes, such as abs() -> labs(), removing
duplicated ops and etc.
Changed patches:
perf diff: Use hists to manage basic blocks per symbol
perf diff: Link same basic blocks among different data
perf diff: Print the basic block cycles diff
v2:
---
Keep standard perf diff format.
Following is the v1 output.
# perf diff --basic-block
# Cycles diff Basic block (start:end)
# ........... .......................
#
-208 hrtimer_interrupt (30b9e0:30ba42)
-157 update_blocked_averages (2bf9f2:2bfa63)
-126 interrupt_entry (c00880:c0093a)
-86 hrtimer_interrupt (30bb29:30bb32)
-74 hrtimer_interrupt (30ba65:30bac4)
-56 update_blocked_averages (2bf980:2bf9d3)
48 update_blocked_averages (2bf934:2bf942)
-35 native_write_msr (267900:26790b)
26 native_irq_return_iret (c00a27:c00a27)
22 rcu_check_callbacks (2febb6:2febdc)
-21 __hrtimer_run_queues (30b220:30b2a3)
19 pvclock_gtod_notify (14ba0:14c1b)
-18 task_tick_fair (2c5d29:2c5d41)
Jin Yao (7):
perf util: Create block_info structure
perf util: Add block_info in hist_entry
perf diff: Check if all data files with branch stacks
perf diff: Use hists to manage basic blocks per symbol
perf diff: Link same basic blocks among different data
perf diff: Print the basic block cycles diff
perf diff: Documentation -c cycles option
tools/perf/Documentation/perf-diff.txt | 17 +-
tools/perf/builtin-diff.c | 404 ++++++++++++++++++++++++++++++++-
tools/perf/ui/stdio/hist.c | 27 +++
tools/perf/util/hist.c | 40 +++-
tools/perf/util/hist.h | 9 +
tools/perf/util/sort.h | 13 ++
tools/perf/util/srcline.c | 4 +-
tools/perf/util/symbol.c | 22 ++
tools/perf/util/symbol.h | 23 ++
tools/perf/util/symbol_conf.h | 4 +-
10 files changed, 551 insertions(+), 12 deletions(-)
--
2.7.4
next reply other threads:[~2019-06-20 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 14:36 Jin Yao [this message]
2019-06-20 14:36 ` [PATCH v4 1/7] perf util: Create block_info structure Jin Yao
2019-06-20 14:36 ` [PATCH v4 2/7] perf util: Add block_info in hist_entry Jin Yao
2019-06-20 14:36 ` [PATCH v4 3/7] perf diff: Check if all data files with branch stacks Jin Yao
2019-06-20 14:36 ` [PATCH v4 4/7] perf diff: Use hists to manage basic blocks per symbol Jin Yao
2019-06-24 7:57 ` Jiri Olsa
2019-06-24 14:49 ` Jin, Yao
2019-06-25 8:50 ` Jiri Olsa
2019-06-25 9:11 ` Jiri Olsa
2019-06-26 0:57 ` Jin, Yao
2019-06-20 14:36 ` [PATCH v4 5/7] perf diff: Link same basic blocks among different data Jin Yao
2019-06-20 14:36 ` [PATCH v4 6/7] perf diff: Print the basic block cycles diff Jin Yao
2019-06-20 14:36 ` [PATCH v4 7/7] perf diff: Documentation -c cycles option Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561041402-29444-1-git-send-email-yao.jin@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox