From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47165C48BD6 for ; Thu, 27 Jun 2019 14:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2313A20644 for ; Thu, 27 Jun 2019 14:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbfF0OtQ convert rfc822-to-8bit (ORCPT ); Thu, 27 Jun 2019 10:49:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38842 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726441AbfF0OtP (ORCPT ); Thu, 27 Jun 2019 10:49:15 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5RElq0k096722 for ; Thu, 27 Jun 2019 10:49:14 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tcwr3qevm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Jun 2019 10:49:14 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Jun 2019 15:49:12 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 27 Jun 2019 15:49:09 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5REn8R040370222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jun 2019 14:49:08 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 90F2DAE051; Thu, 27 Jun 2019 14:49:08 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE059AE055; Thu, 27 Jun 2019 14:49:07 +0000 (GMT) Received: from localhost (unknown [9.199.59.170]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 27 Jun 2019 14:49:07 +0000 (GMT) Date: Thu, 27 Jun 2019 20:19:06 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH v2 2/7] x86/ftrace: Fix use of flags in ftrace_replace_code() To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Masami Hiramatsu , Ingo Molnar , Michael Ellerman , Nicholas Piggin References: <20190627092902.253971d2@gandalf.local.home> In-Reply-To: <20190627092902.253971d2@gandalf.local.home> User-Agent: astroid/0.14.0 (https://github.com/astroidmail/astroid) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 19062714-0028-0000-0000-0000037E3FDE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19062714-0029-0000-0000-0000243E6A81 Message-Id: <1561646838.7py5mwzawl.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-27_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=640 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906270172 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt wrote: > On Thu, 27 Jun 2019 16:53:50 +0530 > "Naveen N. Rao" wrote: > >> In commit a0572f687fb3c ("ftrace: Allow ftrace_replace_code() to be >> schedulable), the generic ftrace_replace_code() function was modified to >> accept a flags argument in place of a single 'enable' flag. However, the >> x86 version of this function was not updated. Fix the same. >> >> Fixes: a0572f687fb3c ("ftrace: Allow ftrace_replace_code() to be schedulable") > > I don't mind this change, but it's not a bug, and I'm not sure it > should have the fixes tag. The reason being, the > FTRACE_MODIFY_ENABLE_FL is only set when ftrace is called by with the > command flag FTRACE_MAY_SLEEP, which is never done on x86. I guess you meant to say that *FTRACE_MODIFY_MAY_SLEEP_FL* is only set with FTRACE_MAY_SLEEP. > > That said, I'm fine with the change as it makes it more robust, but by > adding the fixes tag, you're going to get this into all the stable > code, and I'm not sure that's really necessary. Agreed. Thanks for pointing this out. We can drop this patch from this series and I will re-post this as a simpler cleanup later on. Thanks, Naveen