Re: [PATCH 0/4] tracing: Improve error messages for histogram sorting

[Tom Zanussi <zanussi@kernel.org>]

Hi Masami,

On Fri, 2019-06-28 at 15:16 +0900, Masami Hiramatsu wrote:
> On Thu, 27 Jun 2019 10:35:15 -0500
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > Hi,
> > 
> > These patches add some improvements for histogram sorting,
> > addressing
> > some shortcomings pointed out by Masami.
> > 
> > In order to address the specific problem pointed out by Masami, as
> > well as add additional related error messages, the first patch
> > does some simplification of assignment parsing.
> > 
> > The second patch actually adds the new error messages.
> > 
> > The fourth patch adds a new testcase for hist trigger parsing,
> > similar
> > to the same kind of tests for kprobes and uprobes.  Additional
> > tests
> > covering all possible hist trigger errors should/will be added here
> > in
> > the future.
> > 
> > The third patch just adds a missing hist: prefix to the error log
> > so
> > that the testcases work properly, and which should have been there
> > anyway.
> > 
> > Thanks,
> 
> 
> Hi Tom,
> 
> These patches look good to me :)
> 
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> for all patches. BTW, if you think there is a bug and the 1st one
> fixes it,
> please add Fixes: tag.
> 

Yeah, I'll submit a v2 that adds that.

Thanks for the review,

Tom


> Thank you,
> > 
> > Tom
> > 
> > The following changes since commit
> > a124692b698b00026a58d89831ceda2331b2e1d0:
> > 
> >   ftrace: Enable trampoline when rec count returns back to one
> > (2019-05-25 23:04:43 -0400)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-
> > trace.git ftrace-hist-sort-err-msgs-v1
> > 
> > Tom Zanussi (4):
> >   tracing: Simplify assignment parsing for hist triggers
> >   tracing: Add hist trigger error messages for sort specification
> >   tracing: Add 'hist:' to hist trigger error log error string
> >   tracing: Add new testcases for hist trigger parsing errors
> > 
> >  kernel/trace/trace_events_hist.c                   | 94
> > +++++++++++-----------
> >  .../test.d/trigger/trigger-hist-syntax-errors.tc   | 32 ++++++++
> >  2 files changed, 78 insertions(+), 48 deletions(-)
> >  create mode 100644
> > tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-
> > errors.tc
> > 
> > -- 
> > 2.14.1
> > 
> 
>