From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD41C0650E for ; Wed, 3 Jul 2019 08:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20BB72184C for ; Wed, 3 Jul 2019 08:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbfGCI6d (ORCPT ); Wed, 3 Jul 2019 04:58:33 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:9794 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726400AbfGCI6c (ORCPT ); Wed, 3 Jul 2019 04:58:32 -0400 X-UUID: 97317b77af48444da774bf30f62fe1a9-20190703 X-UUID: 97317b77af48444da774bf30f62fe1a9-20190703 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 122301073; Wed, 03 Jul 2019 16:58:27 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Jul 2019 16:58:25 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 3 Jul 2019 16:58:25 +0800 Message-ID: <1562144305.3550.0.camel@mtksdaap41> Subject: Re: [PATCH] checkpatch: avoid default n From: Yingjoe Chen To: Joe Perches CC: Miles Chen , Andy Whitcroft , , , Date: Wed, 3 Jul 2019 16:58:25 +0800 In-Reply-To: References: <20190703083031.2950-1-miles.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote: > On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote: > > This change reports a warning when "default n" is used. > > > > I have seen several "remove default n" patches, so I think > > it might be helpful to add this test in checkpatch. > > > > tested: > > WARNING: 'default n' is the default value, no need to write it explicitly. > > + default n > > I don't think this is reasonable as there are > several uses like: > > default y > default n if > > For instance: > > arch/alpha/Kconfig-config ALPHA_WTINT > arch/alpha/Kconfig- bool "Use WTINT" if ALPHA_SRM || ALPHA_GENERIC > arch/alpha/Kconfig- default y if ALPHA_QEMU > arch/alpha/Kconfig: default n if ALPHA_EV5 || ALPHA_EV56 || (ALPHA_EV4 && !ALPHA_LCA) > arch/alpha/Kconfig: default n if !ALPHA_SRM && !ALPHA_GENERIC I've sent similar patch in 2016, my version won't complain about these. https://lkml.org/lkml/2016/4/22/580 Joe.C