Re: ima: Replace two seq_printf() calls by seq_puts() in ima_show_template_data_ascii()

Markus Elfring
2019-07-03T09:33:38Z

> So this is probably just a minor performance improvement in a code
> path where it really doesn't matter.

I imagine that another small software adjustment can help a bit
to get nicer run time characteristics also at this place.

>> +++ b/security/integrity/ima/ima_template_lib.c
>> @@ -74,7 +74,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,
>> case DATA_FMT_DIGEST_WITH_ALGO:
>> buf_ptr = strnchr(field_data->data, buflen, ':');
>> if (buf_ptr != field_data->data)
>> - seq_printf(m, "%s", field_data->data);
>> + seq_puts(m, field_data->data);
>>
>> /* skip ':' and '\0' */
>> buf_ptr += 2;
>
> That code looks highly suspect!

Would you like to change this implementation detail any more?

Regards,
Markus