From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D57C606B0 for ; Tue, 9 Jul 2019 09:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBB6C21537 for ; Tue, 9 Jul 2019 09:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbfGIJKz (ORCPT ); Tue, 9 Jul 2019 05:10:55 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:55649 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725975AbfGIJKz (ORCPT ); Tue, 9 Jul 2019 05:10:55 -0400 X-UUID: 9dca87f76bdd4679bd04d6402cac12ea-20190709 X-UUID: 9dca87f76bdd4679bd04d6402cac12ea-20190709 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1636331047; Tue, 09 Jul 2019 17:10:47 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 9 Jul 2019 17:10:43 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 9 Jul 2019 17:10:42 +0800 Message-ID: <1562663442.17100.8.camel@mhfsdcap03> Subject: Re: [PATCH v6 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring CC: Bin Liu , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , , , , , , , , Date: Tue, 9 Jul 2019 17:10:42 +0800 In-Reply-To: <20190708223035.GA7005@bogus> References: <1559648359-6569-1-git-send-email-min.guo@mediatek.com> <1559648359-6569-2-git-send-email-min.guo@mediatek.com> <20190708223035.GA7005@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: F0DCFFEEE23D6BF2E5BB0AABD4DE8DDE5463016EB5873A380B873EE4248B482E2000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Mon, 2019-07-08 at 16:30 -0600, Rob Herring wrote: > On Tue, Jun 04, 2019 at 07:39:14PM +0800, min.guo@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --- > > changes in v6: > > 1. Modify usb connector child node > > > > changes in v5: > > suggested by Rob: > > 1. Modify compatible as > > - compatible : should be one of: > > "mediatek,mt-2701" > > No, should be: mediatek,mt2701-musb OK. > > ... > > followed by "mediatek,mtk-musb" > > 2. Add usb connector child node > > > > changes in v4: > > suggested by Sergei: > > 1. String alignment > > > > changes in v3: > > 1. no changes > > > > changes in v2: > > suggested by Bin: > > 1. Modify DRC to DRD > > suggested by Rob: > > 2. Drop the "-musb" in compatible > > 3. Remove phy-names > > 4. Add space after comma in clock-names > > --- > > .../devicetree/bindings/usb/mediatek,musb.txt | 55 ++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > new file mode 100644 > > index 0000000..7434299 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > @@ -0,0 +1,55 @@ > > +MediaTek musb DRD/OTG controller > > +------------------------------------------- > > + > > +Required properties: > > + - compatible : should be one of: > > + "mediatek,mt-2701" > > + ... > > + followed by "mediatek,mtk-musb" > > + - reg : specifies physical base address and size of > > + the registers > > + - interrupts : interrupt used by musb controller > > + - interrupt-names : must be "mc" > > + - phys : PHY specifier for the OTG phy > > + - dr_mode : should be one of "host", "peripheral" or "otg", > > + refer to usb/generic.txt > > + - clocks : a list of phandle + clock-specifier pairs, one for > > + each entry in clock-names > > + - clock-names : must contain "main", "mcu", "univpll" > > + for clocks of controller > > + > > +Optional properties: > > + - power-domains : a phandle to USB power domain node to control USB's > > + MTCMOS > > + > > +Required child nodes: > > + usb connector node as defined in bindings/connector/usb-connector.txt > > +Optional properties: > > + - id-gpios : input GPIO for USB ID pin. > > + - vbus-gpios : input GPIO for USB VBUS pin. > > + - vbus-supply : reference to the VBUS regulator, needed when supports > > + dual-role mode > > + > > +Example: > > + > > +usb2: usb@11200000 { > > + compatible = "mediatek,mt2701-musb", > > + "mediatek,mtk-musb"; > > + reg = <0 0x11200000 0 0x1000>; > > + interrupts = ; > > + interrupt-names = "mc"; > > + phys = <&u2port2 PHY_TYPE_USB2>; > > + dr_mode = "otg"; > > + clocks = <&pericfg CLK_PERI_USB0>, > > + <&pericfg CLK_PERI_USB0_MCU>, > > + <&pericfg CLK_PERI_USB_SLV>; > > + clock-names = "main","mcu","univpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>; > > + connector{ > > + compatible = "linux,typeb-conn-gpio", "usb-b-connector"; > > linux,typeb-conn-gpio is not an accepted compatible string. The compatible depends on connector driver, currently under review. https://patchwork.kernel.org/patch/10986245 > > + label = "micro-USB"; > > + type = "micro"; > > + id-gpios = <&pio 44 GPIO_ACTIVE_HIGH>; > > + vbus-supply = <&usb_vbus>; > > + }; > > +}; > > -- > > 1.9.1 > > Regards, Min.