From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Steffen Maier <maier@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: Linux 5.3-rc1
Date: Tue, 23 Jul 2019 09:23:34 -0700 [thread overview]
Message-ID: <1563899014.3609.26.camel@HansenPartnership.com> (raw)
In-Reply-To: <20190723161918.GB9140@roeck-us.net>
On Tue, 2019-07-23 at 09:19 -0700, Guenter Roeck wrote:
> On Tue, Jul 23, 2019 at 08:33:15AM -0700, James Bottomley wrote:
> [ ... ]
> >
> > Yes, I think so. Can someone try this, or something like it.
> >
> > Thanks,
> >
> > James
> >
> > ---
> >
> > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> > index 9381171c2fc0..4715671a1537 100644
> > --- a/drivers/scsi/scsi_lib.c
> > +++ b/drivers/scsi/scsi_lib.c
> > @@ -1793,7 +1793,8 @@ void __scsi_init_queue(struct Scsi_Host
> > *shost, struct request_queue *q)
> > dma_set_seg_boundary(dev, shost->dma_boundary);
> >
> > blk_queue_max_segment_size(q, shost->max_segment_size);
> > - blk_queue_virt_boundary(q, shost->virt_boundary_mask);
> > + if (shost->virt_boundary_mask)
> > + blk_queue_virt_boundary(q, shost-
> > >virt_boundary_mask);
> > dma_set_max_seg_size(dev, queue_max_segment_size(q));
> >
> > /*
>
> This fixes the problem for me.
Great, thanks!
I'm thinking this is the more correct fix:
https://lore.kernel.org/linux-block/1563896932.3609.15.camel@HansenPartnership.com/
But we'll see what Jens says.
James
next prev parent reply other threads:[~2019-07-23 16:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 21:33 Linux 5.3-rc1 Linus Torvalds
2019-07-21 22:55 ` Bhaskar Chowdhury
2019-07-22 22:21 ` Guenter Roeck
2019-07-22 23:45 ` James Bottomley
2019-07-23 2:42 ` Guenter Roeck
2019-07-23 5:28 ` James Bottomley
2019-07-23 14:25 ` Steffen Maier
2019-07-23 15:33 ` James Bottomley
2019-07-23 16:19 ` Guenter Roeck
2019-07-23 16:23 ` James Bottomley [this message]
2019-07-23 16:52 ` Guenter Roeck
2019-07-23 16:46 ` Steffen Maier
2019-07-23 5:48 ` Christoph Hellwig
2019-07-23 13:56 ` Guenter Roeck
2019-07-23 14:58 ` Guenter Roeck
2019-07-23 15:14 ` James Bottomley
2019-07-23 15:42 ` Guenter Roeck
2019-07-23 15:34 ` Christoph Hellwig
2019-07-23 15:40 ` Guenter Roeck
2019-07-23 16:18 ` Guenter Roeck
2019-07-25 11:17 ` linux-next: stats (Was: Linux 5.3-rc1) Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563899014.3609.26.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maier@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox