* [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()
@ 2018-01-18 14:05 Wei Yongjun
2018-01-18 14:08 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Wei Yongjun @ 2018-01-18 14:05 UTC (permalink / raw)
To: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Boris Brezillon, Marek Vasut, Cyrille Pitchen
Cc: Wei Yongjun, linux-mtd, linux-kernel, kernel-janitors
Fix to return error code -ENOMEM from the kmem_cache_alloc() error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mtd/ubi/wl.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index 77ab49f..2052a64 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -1617,8 +1617,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
cond_resched();
e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
- if (!e)
+ if (!e) {
+ err = -ENOMEM;
goto out_free;
+ }
e->pnum = aeb->pnum;
e->ec = aeb->ec;
@@ -1637,8 +1639,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
cond_resched();
e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
- if (!e)
+ if (!e) {
+ err = -ENOMEM;
goto out_free;
+ }
e->pnum = aeb->pnum;
e->ec = aeb->ec;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()
2018-01-18 14:05 [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init() Wei Yongjun
@ 2018-01-18 14:08 ` Boris Brezillon
2018-01-18 14:11 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2018-01-18 14:08 UTC (permalink / raw)
To: Wei Yongjun
Cc: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen, linux-mtd,
linux-kernel, kernel-janitors
On Thu, 18 Jan 2018 14:05:05 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fix to return error code -ENOMEM from the kmem_cache_alloc() error
> handling case instead of 0, as done elsewhere in this function.
I guess you've used a static analysis code to detect this problem, can
you name it in the commit message, and paste the error/warning message
it reported next time you submit this kind of patch.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
NAck. I you read the code you'll see that err is initialized to -ENOMEM
here [1], so these changes are actually not needed.
> ---
> drivers/mtd/ubi/wl.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index 77ab49f..2052a64 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -1617,8 +1617,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
> cond_resched();
>
> e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> - if (!e)
> + if (!e) {
> + err = -ENOMEM;
> goto out_free;
> + }
>
> e->pnum = aeb->pnum;
> e->ec = aeb->ec;
> @@ -1637,8 +1639,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
> cond_resched();
>
> e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> - if (!e)
> + if (!e) {
> + err = -ENOMEM;
> goto out_free;
> + }
>
> e->pnum = aeb->pnum;
> e->ec = aeb->ec;
>
[1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/ubi/wl.c?h=next-20180118#n1596
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()
2018-01-18 14:08 ` Boris Brezillon
@ 2018-01-18 14:11 ` Boris Brezillon
2018-01-18 15:34 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2018-01-18 14:11 UTC (permalink / raw)
To: Wei Yongjun
Cc: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen, linux-mtd,
linux-kernel, kernel-janitors
On Thu, 18 Jan 2018 15:08:01 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Thu, 18 Jan 2018 14:05:05 +0000
> Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> > Fix to return error code -ENOMEM from the kmem_cache_alloc() error
> > handling case instead of 0, as done elsewhere in this function.
>
> I guess you've used a static analysis code to detect this problem, can
> you name it in the commit message, and paste the error/warning message
> it reported next time you submit this kind of patch.
>
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> NAck. I you read the code you'll see that err is initialized to -ENOMEM
> here [1], so these changes are actually not needed.
Sorry, just realized I was wrong. It seems that err can be overridden by
[2]. So this patch is indeed fixing a real problem.
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> > ---
> > drivers/mtd/ubi/wl.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> > index 77ab49f..2052a64 100644
> > --- a/drivers/mtd/ubi/wl.c
> > +++ b/drivers/mtd/ubi/wl.c
> > @@ -1617,8 +1617,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
> > cond_resched();
> >
> > e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> > - if (!e)
> > + if (!e) {
> > + err = -ENOMEM;
> > goto out_free;
> > + }
> >
> > e->pnum = aeb->pnum;
> > e->ec = aeb->ec;
> > @@ -1637,8 +1639,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
> > cond_resched();
> >
> > e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> > - if (!e)
> > + if (!e) {
> > + err = -ENOMEM;
> > goto out_free;
> > + }
> >
> > e->pnum = aeb->pnum;
> > e->ec = aeb->ec;
> >
>
> [1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/ubi/wl.c?h=next-20180118#n1596
[2]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/ubi/wl.c?h=next-20180118#n1609
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()
2018-01-18 14:11 ` Boris Brezillon
@ 2018-01-18 15:34 ` Boris Brezillon
2018-01-18 15:46 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2018-01-18 15:34 UTC (permalink / raw)
To: Wei Yongjun
Cc: Artem Bityutskiy, Richard Weinberger, kernel-janitors,
linux-kernel, Marek Vasut, linux-mtd, Cyrille Pitchen,
Brian Norris, David Woodhouse
On Thu, 18 Jan 2018 15:11:32 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Thu, 18 Jan 2018 15:08:01 +0100
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
> > On Thu, 18 Jan 2018 14:05:05 +0000
> > Wei Yongjun <weiyongjun1@huawei.com> wrote:
> >
> > > Fix to return error code -ENOMEM from the kmem_cache_alloc() error
> > > handling case instead of 0, as done elsewhere in this function.
> >
> > I guess you've used a static analysis code to detect this problem, can
> > you name it in the commit message, and paste the error/warning message
> > it reported next time you submit this kind of patch.
> >
> > >
> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > NAck. I you read the code you'll see that err is initialized to -ENOMEM
> > here [1], so these changes are actually not needed.
>
> Sorry, just realized I was wrong. It seems that err can be overridden by
> [2]. So this patch is indeed fixing a real problem.
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Oh, and you can add:
Fixes: f78e5623f45b ("ubi: fastmap: Erase outdated anchor PEBs during attach")
>
> >
> > > ---
> > > drivers/mtd/ubi/wl.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> > > index 77ab49f..2052a64 100644
> > > --- a/drivers/mtd/ubi/wl.c
> > > +++ b/drivers/mtd/ubi/wl.c
> > > @@ -1617,8 +1617,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
> > > cond_resched();
> > >
> > > e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> > > - if (!e)
> > > + if (!e) {
> > > + err = -ENOMEM;
> > > goto out_free;
> > > + }
> > >
> > > e->pnum = aeb->pnum;
> > > e->ec = aeb->ec;
> > > @@ -1637,8 +1639,10 @@ int ubi_wl_init(struct ubi_device *ubi, struct ubi_attach_info *ai)
> > > cond_resched();
> > >
> > > e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> > > - if (!e)
> > > + if (!e) {
> > > + err = -ENOMEM;
> > > goto out_free;
> > > + }
> > >
> > > e->pnum = aeb->pnum;
> > > e->ec = aeb->ec;
> > >
> >
> > [1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/ubi/wl.c?h=next-20180118#n1596
>
> [2]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/ubi/wl.c?h=next-20180118#n1609
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()
2018-01-18 15:34 ` Boris Brezillon
@ 2018-01-18 15:46 ` Richard Weinberger
0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2018-01-18 15:46 UTC (permalink / raw)
To: Boris Brezillon
Cc: Wei Yongjun, Artem Bityutskiy, kernel-janitors, linux-kernel,
Marek Vasut, linux-mtd, Cyrille Pitchen, Brian Norris,
David Woodhouse
Boris, Wei Yongjun,
Am Donnerstag, 18. Januar 2018, 16:34:45 CET schrieb Boris Brezillon:
> On Thu, 18 Jan 2018 15:11:32 +0100
>
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > On Thu, 18 Jan 2018 15:08:01 +0100
> >
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > > On Thu, 18 Jan 2018 14:05:05 +0000
> > >
> > > Wei Yongjun <weiyongjun1@huawei.com> wrote:
> > > > Fix to return error code -ENOMEM from the kmem_cache_alloc() error
> > > > handling case instead of 0, as done elsewhere in this function.
> > >
> > > I guess you've used a static analysis code to detect this problem, can
> > > you name it in the commit message, and paste the error/warning message
> > > it reported next time you submit this kind of patch.
> > >
> > > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > >
> > > NAck. I you read the code you'll see that err is initialized to -ENOMEM
> > > here [1], so these changes are actually not needed.
> >
> > Sorry, just realized I was wrong. It seems that err can be overridden by
> > [2]. So this patch is indeed fixing a real problem.
> >
> > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Oh, and you can add:
>
> Fixes: f78e5623f45b ("ubi: fastmap: Erase outdated anchor PEBs during
> attach")
Good catch!
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-18 15:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-18 14:05 [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init() Wei Yongjun
2018-01-18 14:08 ` Boris Brezillon
2018-01-18 14:11 ` Boris Brezillon
2018-01-18 15:34 ` Boris Brezillon
2018-01-18 15:46 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox