public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Shih <sam.shih@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
	John Crispin <john@phrozen.org>, <linux-pwm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	sam shih <sam.shih@mediatek.com>
Subject: [PATCH v3 8/10] pwm: mediatek: add new property and fix mt7628 pwm
Date: Fri, 16 Aug 2019 15:21:26 +0800	[thread overview]
Message-ID: <1565940088-845-9-git-send-email-sam.shih@mediatek.com> (raw)
In-Reply-To: <1565940088-845-1-git-send-email-sam.shih@mediatek.com>

From: sam shih <sam.shih@mediatek.com>

This fix mt7628 pwm during configure from userspace. The SoC
is legacy MIPS and has no complex clock tree. This patch add property
clock-frequency to the SoC specific data and legacy MIPS SoC need to
configure it in DT. This property is use for period calculation.

Signed-off-by: Sam Shih <sam.shih@mediatek.com>
---
 drivers/pwm/pwm-mediatek.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index d696df7a58fa..922a7543a2b1 100644
--- a/drivers/pwm/pwm-mediatek.c
+++ b/drivers/pwm/pwm-mediatek.c
@@ -53,6 +53,7 @@ struct pwm_mediatek_chip {
 	struct clk *clk_top;
 	struct clk *clk_main;
 	struct clk **clk_pwms;
+	unsigned int clk_freq;
 	const struct pwm_mediatek_of_data *soc;
 };
 
@@ -139,7 +140,10 @@ static int pwm_mediatek_config(struct pwm_chip *chip, struct pwm_device *pwm,
 
 	/* Using resolution in picosecond gets accuracy higher */
 	resolution = (u64)NSEC_PER_SEC * 1000;
-	do_div(resolution, clk_get_rate(clk));
+	if (pc->soc->has_clks)
+		do_div(resolution, clk_get_rate(clk));
+	else
+		do_div(resolution, pc->clk_freq);
 
 	cnt_period = DIV_ROUND_CLOSEST_ULL((u64)period_ns * 1000, resolution);
 	while (cnt_period > 8191) {
@@ -216,6 +220,7 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
 	struct pwm_mediatek_chip *pc;
 	struct resource *res;
 	unsigned int npwms;
+	unsigned int clk_freq;
 	int ret;
 
 	pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
@@ -265,6 +270,14 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
 			if (IS_ERR(pc->clk_pwms[i]))
 				return PTR_ERR(pc->clk_pwms[i]);
 		}
+	} else {
+		ret = of_property_read_u32(np, "clock-frequency",
+						&clk_freq);
+		if (ret < 0) {
+			dev_err(&pdev->dev, "failed to get clk_freq\n");
+			return ret;
+		}
+		pc->clk_freq = clk_freq;
 	}
 
 	platform_set_drvdata(pdev, pc);
-- 
2.17.1


  parent reply	other threads:[~2019-08-16  7:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16  7:21 [PATCH v3 0/10] Add mt7629 and fix mt7628 pwm Sam Shih
2019-08-16  7:21 ` [PATCH v3 1/10] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-08-16  7:34   ` Uwe Kleine-König
2019-08-16  7:21 ` [PATCH v3 2/10] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-08-16  8:49   ` Uwe Kleine-König
2019-08-16  7:21 ` [PATCH v3 3/10] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-08-16  7:21 ` [PATCH v3 4/10] dt-bindings: pwm: add a property "num-pwms" Sam Shih
2019-08-16  7:21 ` [PATCH v3 5/10] arm64: dts: mt7622: add a property "num-pwms" for PWM node Sam Shih
2019-08-16  7:21 ` [PATCH v3 6/10] arm: dts: mt7623: " Sam Shih
2019-08-16  7:21 ` [PATCH v3 7/10] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-08-16 21:02   ` Rob Herring
2019-08-16  7:21 ` Sam Shih [this message]
2019-08-16  7:21 ` [PATCH v3 9/10] dt-bindings: pwm: update bindings for MT7628 SoC Sam Shih
2019-08-16  7:21 ` [PATCH 10/10] arm: dts: mediatek: add mt7629 pwm support Sam Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565940088-845-9-git-send-email-sam.shih@mediatek.com \
    --to=sam.shih@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=ryder.lee@mediatek.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox