Re: [PATCH 2/3] Documentation: Describe V4L2_CID_PIXEL_SIZE

[Philipp Zabel <p.zabel@pengutronix.de>]

On Mon, 2019-08-19 at 14:17 +0200, Ricardo Ribalda Delgado wrote:
> New control to pass to userspace the width/height of a pixel. Which is
> needed for 3D calibration and lens selection.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
> ---
>  Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> index 51c1d5c9eb00..670c57a6f622 100644
> --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> @@ -510,6 +510,12 @@ enum v4l2_scene_mode -
>      value down. A value of zero stops the motion if one is in progress
>      and has no effect otherwise.
>  
> +``V4L2_CID_PIXEL_SIZE (struct)``
> +    This control returns the pixel size in nanometres. The struct provides
> +    the width and the height in separated fields to take into consideration
> +    asymmetric pixels and/or hardware binning.
> +    This control is required for automatic calibration of the sensor.
> +
>  .. [#f1]
>     This control may be changed to a menu control in the future, if more
>     options are required.

I suppose this is a common term, but should it be mentioned that pixel
size is the same as unit cell size, and not necessarily the size of the
light sensitive area? Just in case the effective fill-factor is < 100%.

regards
Philipp