public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gerald BAEZA <gerald.baeza@st.com>
To: "peterz@infradead.org" <peterz@infradead.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"jolsa@redhat.com" <jolsa@redhat.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Gerald BAEZA <gerald.baeza@st.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>
Subject: [PATCH] libperf: fix alignment trap in perf stat
Date: Thu, 22 Aug 2019 09:07:01 +0000	[thread overview]
Message-ID: <1566464769-16374-1-git-send-email-gerald.baeza@st.com> (raw)

Following the patch 'perf stat: Fix --no-scale', an
alignment trap happens in process_counter_values()
on ARMv7 platforms due to the attempt to copy non
64 bits aligned double words (pointed by 'count')
via a NEON vectored instruction ('vld1' with 64
bits alignment constraint).

This patch sets a 64 bits alignment constraint on
'contents[]' field in 'struct xyarray' since the
'count' pointer used above points to such a
structure.

Signed-off-by: Gerald Baeza <gerald.baeza@st.com>
---
 tools/perf/lib/include/internal/xyarray.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/lib/include/internal/xyarray.h b/tools/perf/lib/include/internal/xyarray.h
index 3bf70e4..51e35d6 100644
--- a/tools/perf/lib/include/internal/xyarray.h
+++ b/tools/perf/lib/include/internal/xyarray.h
@@ -2,6 +2,7 @@
 #ifndef __LIBPERF_INTERNAL_XYARRAY_H
 #define __LIBPERF_INTERNAL_XYARRAY_H
 
+#include <linux/compiler.h>
 #include <sys/types.h>
 
 struct xyarray {
@@ -10,7 +11,7 @@ struct xyarray {
 	size_t entries;
 	size_t max_x;
 	size_t max_y;
-	char contents[];
+	char contents[] __aligned(8);
 };
 
 struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size);
-- 
2.7.4

             reply	other threads:[~2019-08-22  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  9:07 Gerald BAEZA [this message]
2019-08-22 15:24 ` [PATCH] libperf: fix alignment trap in perf stat Arnaldo Carvalho de Melo
2019-08-23 12:29 ` [tip: perf/core] libperf: Fix alignment trap with xyarray contents in 'perf stat' tip-bot2 for Gerald BAEZA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1566464769-16374-1-git-send-email-gerald.baeza@st.com \
    --to=gerald.baeza@st.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@st.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox