Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

Ran Bi
2019-08-22T11:50:21Z

On Thu, 2019-08-22 at 11:20 +0200, Alexandre Belloni wrote:
> On 22/08/2019 11:12:29+0200, Matthias Brugger wrote:
> >
> >
> > On 01/08/2019 13:01, Ran Bi wrote:
> > > This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but
> > > had different architecture compared with MT7622 RTC.
> > >
> > > Signed-off-by: Ran Bi <ran.bi@mediatek.com>
> > > ---
> > > drivers/rtc/Kconfig | 10 +
> > > drivers/rtc/Makefile | 1 +
> > > drivers/rtc/rtc-mt2712.c | 444 +++++++++++++++++++++++++++++++++++++++
> >
> > Can't we just adjust rtc-mt7622.c (and rename it) to unify the source for both
> > devices. What is the difference that we need to write a driver of our own?
> >
>
> If they are compatible, this is the way to go but the file can't be
> renamed (and that is fine).
>
>

They are not compatible. Both registers and operating methods are
different.

Best Regards,
Ran