Re: [PATCH v7 2/2] Tracepoint: register/unregister struct tracepoint

Steven Rostedt
2014-03-21T19:40:05Z

On Fri, 21 Mar 2014 01:19:02 -0400

> diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> index 4e4cc28..1592c1c 100644
> --- a/include/linux/ftrace_event.h
> +++ b/include/linux/ftrace_event.h
> @@ -230,6 +230,7 @@ struct ftrace_event_call {
> struct list_head list;
> struct ftrace_event_class *class;
> char *name;
> + struct tracepoint *tp;

This change right here just added 17K to the kernel (on a minimum config):

text data bss dec hex filename
8425515 2018936 1302528 11746979 b33ea3 vmlinux.orig
8424914 2036472 1302528 11763914 b380ca vmlinux

The two are redundant. Might as well remove .name and then
use .tp->name for referencing the name of the event.

-- Steve

> struct trace_event event;
> const char *print_fmt;
> struct event_filter *filter;