From: Keith Owens <kaos@ocs.com.au>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
horms@verge.net.au, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, ak@suse.de, vgoyal@in.ibm.com,
mbligh@google.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/10] safe_apic_wait_icr_idle - i386
Date: Wed, 25 Apr 2007 22:55:01 +1000 [thread overview]
Message-ID: <15716.1177505701@ocs3.ocs.com.au> (raw)
In-Reply-To: Your message of "Wed, 25 Apr 2007 20:13:28 +0900." <1177499608.17974.9.camel@sebastian.intellilink.co.jp>
Fernando Luis =?ISO-8859-1?Q?V=E1zquez?= Cao (on Wed, 25 Apr 2007 20:13:28 +0900) wrote:
>+static __inline__ unsigned long safe_apic_wait_icr_idle(void)
>+{
>+ unsigned long send_status;
>+ int timeout;
>+
>+ timeout = 0;
>+ do {
>+ udelay(100);
>+ send_status = apic_read(APIC_ICR) & APIC_ICR_BUSY;
>+ } while (send_status && (timeout++ < 1000));
>+
>+ return send_status;
>+}
>+
safe_apic_wait_icr_idle() as coded guarantees a minimum 100 usec delay
before sending the IPI, this extra delay is unnecessary. Change it to
do {
send_status = apic_read(APIC_ICR) & APIC_ICR_BUSY;
if (send_status)
break;
udelay(100);
} while (timeout++ < 1000);
next prev parent reply other threads:[~2007-04-25 13:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 11:03 [RFC PATCH 0/10] apic_wait_icr_idle issues and possible solutions Fernando Luis Vázquez Cao
2007-04-25 11:13 ` [PATCH 1/10] safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 12:55 ` Keith Owens [this message]
2007-04-25 12:59 ` Fernando Luis Vázquez Cao
2007-04-25 13:16 ` Andi Kleen
2007-04-25 11:15 ` [PATCH 2/10] safe_apic_wait_icr_idle - x86_64 Fernando Luis Vázquez Cao
2007-04-25 12:26 ` Andi Kleen
2007-04-25 12:55 ` Fernando Luis Vázquez Cao
2007-04-25 13:11 ` Andi Kleen
2007-04-25 13:32 ` Fernando Luis Vázquez Cao
2007-04-25 11:19 ` [PATCH 3/10] smpboot: use safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:21 ` [PATCH 4/10] smpboot: use safe_apic_wait_icr_idle - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:26 ` [PATCH 5/10] __inquire_remote_apic: use safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:27 ` [PATCH 6/10] inquire_remote_apic: use safe_apic_wait_icr_idle - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:37 ` [PATCH 7/10] __send_IPI_dest_field - i386 Fernando Luis Vázquez Cao
2007-04-25 11:39 ` [PATCH 8/10] __send_IPI_dest_field - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:49 ` [PATCH 9/10] Use safe_apic_wait_icr_idle in safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:51 ` [PATCH 10/10] Use safe_apic_wait_icr_idle in __send_IPI_dest_field - x86_64 Fernando Luis Vázquez Cao
2007-04-25 12:33 ` Andi Kleen
2007-04-25 12:52 ` Fernando Luis Vázquez Cao
2007-04-26 6:48 ` [RFC PATCH 0/10] apic_wait_icr_idle issues and possible solutions Vivek Goyal
2007-04-26 7:20 ` Fernando Luis Vázquez Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15716.1177505701@ocs3.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=fernando@oss.ntt.co.jp \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox