Re: [PATCH v1 5/6] KEYS: measure queued keys

Lakshmi Ramasubramanian
2019-10-23T17:35:01Z

On 10/23/19 6:23 AM, Mimi Zohar wrote:

> The ordering of this patch set is awkward.  It should first introduce
> a generic method for measuring keys based on the keyring.  Then add
> the additional support needed for the specific builtin_trusted_keys
> keyring usecase.

Would the following ordering of the patch set be acceptable:

=> PATCH 0/5: Cover letter

=> PATCH 1/5: Define the enum "hook(BUILTIN_TRUSTED_KEYS)" in ima.h

=> PATCH 2/5: Define ima hook
This will initially do nothing if ima is not yet
initialized.
Call process_buffer_measurement() if ima is initialized.

=> PATCH 3/5: key_create_or_update change and the call to ima hook

=> PATCH 4/5: Queue\De-Queue of key measurement requests.
Enable queuing of key in the ima hook if ima is not
initialized.

=> PATCH 5/5: ima policy to enable measurement of keys which will
enable end-to-end working of this feature.

thanks,
-lakshmi