The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Praveen Chaudhary <praveen5582@gmail.com>
To: fw@strlen.de
Cc: astracner@linkedin.com, davem@davemloft.net,
	kadlec@netfilter.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, pablo@netfilter.org,
	praveen5582@gmail.com, zxu@linkedin.com
Subject: RE: [PATCH] [netfilter]: Fix skb->csum calculation when netfilter
Date: Wed, 23 Oct 2019 13:56:02 -0700	[thread overview]
Message-ID: <1571864162-9097-1-git-send-email-pchaudhary@linkedin.com> (raw)
In-Reply-To: <20191023193337.GP25052@breakpoint.cc>

Hi Florian 

Thanks for the review,

inet_proto_csum_replace16 is called from many places, whereas this fix is applicable only for nf_nat_ipv6_csum_update, where we need to update skb->csum for ipv6 src/dst address change. 
Also my point is, inet_proto_csum_replace16 is updating skb->csum for change in udp header checksum field, but that is not complete. So, I added a new function. Basically, I used a safe apprioach to fix it, without impacting other cases. Let me know other options,  I am open to suggestions.

More importantly, I hope this is clear that the current code does not update skb->csum completely. Which is a bug. Thanks again.

  reply	other threads:[~2019-10-23 20:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 19:02 [PATCH] Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet Praveen Chaudhary
2019-10-23 19:02 ` [PATCH] [netfilter]: " Praveen Chaudhary
2019-10-23 19:33   ` Florian Westphal
2019-10-23 20:56     ` Praveen Chaudhary [this message]
     [not found]     ` <CAJ_cd4qHM3kqz24Uywpyyz0mPz7axiNZk0Q385ROd4O8XZ11fA@mail.gmail.com>
2019-10-24  1:12       ` Florian Westphal
2019-10-24  5:19         ` [netfilter]: Fix skb->csum calculation when netfilter Praveen Chaudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571864162-9097-1-git-send-email-pchaudhary@linkedin.com \
    --to=praveen5582@gmail.com \
    --cc=astracner@linkedin.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=zxu@linkedin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox