Re: [PATCH] 2.4.27 - MTD cfi_cmdset_0002.c - Duplicate cleanup in error path

[<bkgoodman@bradgoodman.com>]

I noticed it in the 2.4.28-pre1 changelog.

I had concidered doing it has he described - I figured though as a
first-time submitter, the less I touched, the more comfortable people
would feel with it ;-)

Thanks,

-BKG

>
> Applied Rainer's patch, its equivalent and I his
> "consisteny with other algorithms" point is a good one.
>
> Thanks guys!
>
> On Sat, Jul 24, 2004 at 03:14:03PM +0800, Rainer Weikusat wrote:
>> "bradgoodman.com" <bkgoodman@bradgoodman.com> writes:
>> > Patch to 2.4.x: Corrects an obvious error where all of the cleanups
>> are done twice in the event of a chip programming error. This can
>> result in kernel BUG() getting called on subsequent programming
>> attempts.
> <snip>
>> That way, it is consistent with the other low-level chip access
>> functions. But the algorithm is per se buggy, anyway, because except
>> if DQ5 was raised before, the chip is not 'ready' (for reading array
>> data), but still in programming mode and will remain there until the
>> 'embedded programming algorithm' stops, because (according to the
>> docs) a reset command will not be accepted until DQ5 has been raised
>> and the opportunityto check for that is gone after the syscall
>> returned to the caller.