From: Can Guo <cang@codeaurora.org>
To: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, cang@codeaurora.org
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Subhash Jadavani <subhashj@codeaurora.org>,
Tomas Winkler <tomas.winkler@intel.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v1 4/5] scsi: ufs: Avoid messing up the compl_time_stamp of lrbs
Date: Fri, 8 Nov 2019 00:15:30 -0800 [thread overview]
Message-ID: <1573200932-384-5-git-send-email-cang@codeaurora.org> (raw)
In-Reply-To: <1573200932-384-1-git-send-email-cang@codeaurora.org>
To be on the safe side, do not touch one lrb after clear its slot in the
lrb_in_use bitmap to avoid messing up the next task which would possibly
occupy this lrb.
Signed-off-by: Can Guo <cang@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8e7c362..5950a7c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4902,12 +4902,14 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
cmd->result = result;
/* Mark completed command as NULL in LRB */
lrbp->cmd = NULL;
+ lrbp->compl_time_stamp = ktime_get();
clear_bit_unlock(index, &hba->lrb_in_use);
/* Do not touch lrbp after scsi done */
cmd->scsi_done(cmd);
__ufshcd_release(hba);
} else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||
lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
+ lrbp->compl_time_stamp = ktime_get();
if (hba->dev_cmd.complete) {
ufshcd_add_command_trace(hba, index,
"dev_complete");
@@ -4916,8 +4918,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
}
if (ufshcd_is_clkscaling_supported(hba))
hba->clk_scaling.active_reqs--;
-
- lrbp->compl_time_stamp = ktime_get();
}
/* clear corresponding bits of completed commands */
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-11-08 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573200932-384-1-git-send-email-cang@codeaurora.org>
2019-11-08 8:15 ` [PATCH v1 1/5] scsi: ufs: Recheck bkops level if bkops is disabled Can Guo
2019-11-12 7:10 ` Avri Altman
2019-11-13 21:35 ` [EXT] " Bean Huo (beanhuo)
2019-11-08 8:15 ` [PATCH v1 2/5] scsi: ufs: Add new bit field PA_INIT to UECDL register Can Guo
2019-11-12 7:53 ` Avri Altman
2019-11-13 0:41 ` cang
2019-11-08 8:15 ` [PATCH v1 3/5] scsi: ufs: Update VCCQ2 and VCCQ min voltage hard codes Can Guo
2019-11-12 7:56 ` Avri Altman
2019-11-13 2:56 ` cang
2019-11-08 8:15 ` Can Guo [this message]
2019-11-12 8:06 ` [PATCH v1 4/5] scsi: ufs: Avoid messing up the compl_time_stamp of lrbs Avri Altman
2019-11-08 8:15 ` [PATCH v1 5/5] scsi: ufs: Complete pending requests in host reset and restore path Can Guo
2019-11-13 2:24 ` Alim Akhtar
2019-11-13 3:01 ` cang
2019-11-13 22:04 ` [EXT] " Bean Huo (beanhuo)
2019-11-14 1:03 ` cang
2019-11-14 1:18 ` cang
2019-11-14 13:03 ` Bean Huo (beanhuo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573200932-384-5-git-send-email-cang@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).