From: Giovanni Gherdovich <ggherdovich@suse.cz>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: remove "ipc" from list of expected toplevel directories
Date: Fri, 08 Nov 2019 17:27:59 +0100 [thread overview]
Message-ID: <1573230479.5838.7.camel@suse.cz> (raw)
In-Reply-To: <20191108160428.9632-1-ggherdovich@suse.cz>
On Fri, 2019-11-08 at 17:04 +0100, Giovanni Gherdovich wrote:
> checkpatch.pl uses a list of expected directory names to understand if it's
> being run from the top of a kernel tree. Commit 76128326f97c ("toplevel:
> Move ipc/ to kernel/ipc/: move the files") removed a toplevel directory, so
> checkpatch.pl need to update its list.
>
> Signed-off-by: Giovanni Gherdovich <ggherdovich@suse.cz>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..93b8fd1eea57 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1099,7 +1099,7 @@ sub top_of_kernel_tree {
> my @tree_check = (
> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> - "fs", "init", "ipc", "kernel", "lib", "scripts",
> + "fs", "init", "kernel", "lib", "scripts",
> );
>
> foreach my $check (@tree_check) {
Nope, this was already fixed by Yunfeng Ye with
https://lore.kernel.org/lkml/bd70558e-5126-6460-81d7-edf72cbbce7a@huawei.com/
plus the ipc/ directory is now back in its place.
Sorry for the noise,
Giovanni
prev parent reply other threads:[~2019-11-08 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 16:04 [PATCH] checkpatch: remove "ipc" from list of expected toplevel directories Giovanni Gherdovich
2019-11-08 16:27 ` Giovanni Gherdovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573230479.5838.7.camel@suse.cz \
--to=ggherdovich@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox