Re: [PATCH v2 02/18] firmware: qcom_scm: Add funcnum IDs

Stephen Boyd
2019-11-15T23:30:49Z

Quoting Elliot Berman (2019-11-12 13:22:38)
> Add LEGACY_FUNCNUM to qcom_scm-32.c and move SMCCC_FUNCNUM closer to
> other smccc-specific macros.
>
> Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> ---
> drivers/firmware/qcom_scm-32.c | 8 +++++---
> drivers/firmware/qcom_scm-64.c | 3 +--
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c
> index 5d52641..5077fcf 100644
> --- a/drivers/firmware/qcom_scm-32.c
> +++ b/drivers/firmware/qcom_scm-32.c
> @@ -38,6 +38,8 @@ static struct qcom_scm_entry qcom_scm_wb[] = {
>
> static DEFINE_MUTEX(qcom_scm_lock);
>
> +#define LEGACY_FUNCNUM(s, c) (((s) << 10) | ((c) & 0x3ff))

Same name comment here. Otherwise

Reviewed-by: Stephen Boyd <swboyd@chromium.org>