Re: [PATCH v2 01/18] firmware: qcom_scm: Rename macros and structures

eberman
2019-11-16T01:19:17Z

On 2019-11-15 15:27, Stephen Boyd wrote:
> ... to here I don't understand why any of it needs to change. It looks
> like a bunch of churn and it conflates qcom SCM calls with SMCCC which
> is not desirable. Those two concepts are different.

I can see the confusion. The goal with this patch is to make it more
clear which
macros and structures are for SCM interface from those which deal with
the
implementation of how an SCM call is implemented with the smc
instruction. It's
not presently clear that struct qcom_scm_response (for instance) is only
relevant in the context of legacy convention.

I choose the name "legacy" since only older firmwares use it and having
"scm_buffer_get_command_buffer" seems even more confusing to me! "SMCCC"
was
chosen for lack of a better name.

Additionally, the concern with having qcom_scm_ prefix on these
functions
(especially legacy_get_*_buffer()) is you get long function names which
didn't
seem desirable. If the long names are preferable, I can update series
with the
longer form of the names.

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,