Re: [PATCH 6/6] x86: intel_pstate: handle runtime turbo disablement/enablement in freq. invariance

Giovanni Gherdovich
2019-11-13T12:20:38Z

On Wed, 2019-11-13 at 05:28 +0800, kbuild test robot wrote:
> Hi Giovanni,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on tip/sched/core]
> [cannot apply to v5.4-rc7 next-20191111]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Giovanni-Gherdovich/Add-support-for-frequency-invariance-for-some-x86/20191113-035438
> base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a0e813f26ebcb25c0b5e504498fbd796cca1a4ba
> config: i386-randconfig-e001-201945 (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/cpufreq/intel_pstate.c: In function 'intel_pstate_update_limits':
> > > drivers/cpufreq/intel_pstate.c:925:3: error: implicit declaration of function 'set_arch_max_freq' [-Werror=implicit-function-declaration]
>
> set_arch_max_freq(global.turbo_disabled);
> ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>

Good bot. I'm defining the function set_arch_max_freq only if CONFIG_SMP,
I forgot to provide a definition (with empty body) in the other case.

Resending.

Giovanni

> vim +/set_arch_max_freq +925 drivers/cpufreq/intel_pstate.c
>
> 913
> 914 static void intel_pstate_update_limits(unsigned int cpu)
> 915 {
> 916 mutex_lock(&intel_pstate_driver_lock);
> 917
> 918 update_turbo_state();
> 919 /*
> 920 * If turbo has been turned on or off globally, policy limits for
> 921 * all CPUs need to be updated to reflect that.
> 922 */
> 923 if (global.turbo_disabled_mf != global.turbo_disabled) {
> 924 global.turbo_disabled_mf = global.turbo_disabled;
> > 925 set_arch_max_freq(global.turbo_disabled);
> 926 for_each_possible_cpu(cpu)
> 927 intel_pstate_update_max_freq(cpu);
> 928 } else {
> 929 cpufreq_update_policy(cpu);
> 930 }
> 931
> 932 mutex_unlock(&intel_pstate_driver_lock);
> 933 }
> 934
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation