From: Philipp Reisner <philipp.reisner@linbit.com>
To: Nick Wang <nwang@suse.com>
Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [Drbd-dev] [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid
Date: Fri, 31 Jul 2015 14:50:53 +0200 [thread overview]
Message-ID: <1574351.c1nomEfrHy@fat-tyre> (raw)
In-Reply-To: <1436776744-3135-3-git-send-email-nwang@suse.com>
Hi Nick,
When introducing new fields alsways mark them as optional. Otherwise
a new kernel/module code would refuse netlink messages from older
drbd-utils:
> + __flg_field(2, DRBD_GENLA_F_MANDATORY, zap_devices)
__flg_field(2, /* OPTIONAL */ 0, zap_devices)
best regards,
Phil
next prev parent reply other threads:[~2015-07-31 12:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 8:38 [Patch v2 00/10] Zero out devices instead of initial full sync Nick Wang
2015-07-13 8:38 ` [Patch v2 01/10] drbd: Fix the wrong logic of moving history Nick Wang
2015-07-13 8:38 ` [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid Nick Wang
2015-07-31 12:50 ` Philipp Reisner [this message]
2015-07-13 8:38 ` [Patch v2 03/10] drbd: A function to zero out drbd backing device Nick Wang
2015-07-13 8:38 ` [Patch v2 04/10] drbd: New packet P_ZERO_OUT Nick Wang
2015-07-13 8:38 ` [Patch v2 05/10] drbd: Functions to notify peer node to zero out Nick Wang
2015-07-13 8:39 ` [Patch v2 06/10] drbd: Wapper for zeroing out device by worker Nick Wang
2015-07-13 8:39 ` [Patch v2 07/10] drbd: Flags for background drbd device work Nick Wang
2015-07-13 8:39 ` [Patch v2 08/10] drbd: Function to work with packet P_ZERO_OUT Nick Wang
2015-07-13 8:39 ` [Patch v2 09/10] drbd: Handle zero out command from peer node Nick Wang
2015-07-13 8:39 ` [Patch v2 10/10] drbd: Handle new-current-uuid --zap-devices Nick Wang
2015-07-31 12:48 ` [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Philipp Reisner
2015-08-06 10:04 ` [PATCH v3 0/1] Zeroout/discard " Nick Wang
2015-08-06 10:04 ` [PATCH] drbd: Support zeroout device " Nick Wang
2015-08-18 15:03 ` Lars Ellenberg
2015-08-21 3:26 ` 答复： " Nick Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574351.c1nomEfrHy@fat-tyre \
--to=philipp.reisner@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nwang@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox