From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbdKIRIf (ORCPT ); Thu, 9 Nov 2017 12:08:35 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:16026 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdKIRIc (ORCPT ); Thu, 9 Nov 2017 12:08:32 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171109170830epoutp010aa74104aaa8d9a595a097bf42d7ae33~1ee1pxL6j0095700957epoutp01F X-AuditID: b6c32a48-8edff7000000103e-b3-5a048b8defa1 From: Bartlomiej Zolnierkiewicz To: Kees Cook Cc: Benjamin Herrenschmidt , Tomi Valkeinen , David Lechner , Daniel Vetter , Sean Paul , Jean Delvare , Hans de Goede , "Gustavo A. R. Silva" , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: Convert timers to use timer_setup() Date: Thu, 09 Nov 2017 18:08:26 +0100 Message-id: <15752127.NCT7iFVURk@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20171024152026.GA104655@beast> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsWy7bCmqW5vN0uUwarjKhYfmlqZLRY+vMts sahBzOLK1/dsFlv3qFq8OT6dyWLp3U9sFme6cy1O9H1gtbi8aw6bxewl/SwWdzecZbRYP/8W mwOvx+yGiywe6w6qeuz9toDFo+dNC6vHp/6TrB73u48zebzfd5XNY/Ppao/jN7YzeXzeJBfA FcVlk5Kak1mWWqRvl8CVcefENNaCe3wVMw50MjYwbuXpYuTkkBAwkTh0rpexi5GLQ0hgB6PE qj3LoZzvjBKbvhxmgalqP7qVGSKxgVFiwZtuVgjnK6PEwu09TCBVbAJWEhPbVzGC2CICqhLf LzWDdTALnGCWuNj0lRUkISzgJtFwaQlYEQtQ0bspB8HivAJaEte+T2QGsUUFvCS27GsHG8op oCOxZcc/ZogaQYkfk++BncQsIC+xb/9UVghbR+LssXWMEKe2s0v8u8EEYbtIrNjzhBnCFpZ4 dXwLO4QtLfFs1Uao+umMEtt/S4AcKiGwGRgAuydAFVlLHD5+EWoBn0TH4b9AcQ6gOK9ER5sQ RImHxKS+61C7HCVmTjoO1iokUC8xY+U/tgmMsrOQnD0LydmzkJy9gJF5FaNYakFxbnpqsVGB iV5xYm5xaV66XnJ+7iZGcCrS8tjBeOCczyFGAQ5GJR7eF6uYo4RYE8uKK3MPMUpwMCuJ8HLW s0QJ8aYkVlalFuXHF5XmpBYfYpTmYFES563bdi1CSCA9sSQ1OzW1ILUIJsvEwSnVwOi58/oF F6UP1lk72iP2771U7cHCzCvvN626TGt9k3b42Q3F/yomCyhIToltFDyXdc+Lj+3yvbDXMiye eitm1X3f5mcW+cd7lndjWlF3+UvGnX5LYidv5LnJUZHXLNpi0XfO4saBnhvRf7aar53Zs8qa j1NP1jxsnYTvVYEippc5erVTdQsDlViKMxINtZiLihMB5gb+CUEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42I5/e+xoG5vN0uUwdvz3BYfmlqZLRY+vMts sahBzOLK1/dsFlv3qFq8OT6dyWLp3U9sFme6cy1O9H1gtbi8aw6bxewl/SwWdzecZbRYP/8W mwOvx+yGiywe6w6qeuz9toDFo+dNC6vHp/6TrB73u48zebzfd5XNY/Ppao/jN7YzeXzeJBfA FcVlk5Kak1mWWqRvl8CVcefENNaCe3wVMw50MjYwbuXpYuTkkBAwkWg/upW5i5GLQ0hgHaPE x9132SCcr4wSU9s+sYBUsQlYSUxsX8UIYosIqEp8v9QM1sEscIJZYt7BaawgCWEBN4mGS0vA iliAit5NOQgW5xXQkrj2fSIziC0q4CWxZV87E4jNKaAjsWXHP6jVjYwS3w5MZIFoEJT4Mfke mM0sIC+xb/9UVghbS2L9zuNMExj5ZyEpm4WkbBaSsgWMzKsYJVMLinPTc4uNCozyUsv1ihNz i0vz0vWS83M3MQLjZ9thrf4djI+XxB9iFOBgVOLhdVjLHCXEmlhWXJl7iFGCg1lJhJezniVK iDclsbIqtSg/vqg0J7X4EKM0B4uSOC9//rFIIYH0xJLU7NTUgtQimCwTB6dUA6PLkTUTOW89 Vzx5o3pbUaDd+R+T7PLCd4cos5tdjE00bHx7/nDStNUHlx25l9CsyxnsXXIk/X4+f9FOx4fR D3con/x6VPI8/287NvWLl8OOb9VofNil/H92e9erCayTjjJLiuh+f1CwsmvBjJ1uz5k0nhdJ PftxY5pq2MsfDt/XiTCYvb+8ek6xEktxRqKhFnNRcSIAIqMM+psCAAA= X-CMS-MailID: 20171109170829epcas2p35a1f9e66cecdd51e60fff53c2f029124 X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171024152032epcas3p4976e268e33d58750b7c09380e857bba0 X-RootMTR: 20171024152032epcas3p4976e268e33d58750b7c09380e857bba0 References: <20171024152026.GA104655@beast> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 24, 2017 08:20:26 AM Kees Cook wrote: > diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c > index 933619da1a94..e88447eac32c 100644 > --- a/drivers/video/fbdev/pxa3xx-gcu.c > +++ b/drivers/video/fbdev/pxa3xx-gcu.c > @@ -513,16 +513,10 @@ pxa3xx_gcu_mmap(struct file *file, struct vm_area_struct *vma) > #ifdef PXA3XX_GCU_DEBUG_TIMER > static struct timer_list pxa3xx_gcu_debug_timer; > > -static void pxa3xx_gcu_debug_timedout(unsigned long ptr) > +static void pxa3xx_gcu_debug_timedout(struct timer_list *unused) > { > - struct pxa3xx_gcu_priv *priv = (struct pxa3xx_gcu_priv *) ptr; > - > QERROR("Timer DUMP"); QERROR() macro is using priv so this code now fails to build. [ Please compile these timer changes with PXA3XX_GCU_DEBUG and PXA3XX_GCU_DEBUG_TIMER defined. ] Also please port your changes over fbdvev-for-next tree as currently this patch doesn't apply (fbdev tree contains "video: fbdev: pxa3xx_gcu: Use setup_timer and mod_timer" cleanup). > - /* init the timer structure */ > - init_timer(&pxa3xx_gcu_debug_timer); > - pxa3xx_gcu_debug_timer.function = pxa3xx_gcu_debug_timedout; > - pxa3xx_gcu_debug_timer.data = ptr; > pxa3xx_gcu_debug_timer.expires = jiffies + 5*HZ; /* one second */ > > add_timer(&pxa3xx_gcu_debug_timer); > @@ -530,7 +524,9 @@ static void pxa3xx_gcu_debug_timedout(unsigned long ptr) > > static void pxa3xx_gcu_init_debug_timer(void) > { > - pxa3xx_gcu_debug_timedout((unsigned long) &pxa3xx_gcu_debug_timer); > + /* init the timer structure */ > + timer_setup(&pxa3xx_gcu_debug_timer, pxa3xx_gcu_debug_timedout, 0); > + pxa3xx_gcu_debug_timedout(NULL); > } > #else > static inline void pxa3xx_gcu_init_debug_timer(void) {} Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics