From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Maxime Ripard <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-omap@vger.kernel.org>, Bin Liu <b-liu@ti.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] usb: musb: replace all unsigned data type to unsigned int
Date: Thu, 5 Dec 2019 22:52:58 +0800 [thread overview]
Message-ID: <1575557578.6727.2.camel@mtkswgap22> (raw)
In-Reply-To: <20191205101216.GC1337@shell.armlinux.org.uk>
On Thu, 2019-12-05 at 10:12 +0000, Russell King - ARM Linux admin wrote:
> On Thu, Dec 05, 2019 at 02:01:17PM +0800, Macpaul Lin wrote:
> > Simply replace all 'unsigned' data type in musb driver to
> > 'unsigned int' because it has been complained by gerrit
> > checkpatch service.
>
> "unsigned" is perfectly legal standard C. The policy for net related
> code is to abhor it, but there is nothing in the kernel style
> guidelines that prevents its use in the rest of the kernel.
>
> AFAICS there is no need for this churn.
Thanks for your reply.
I'll bring this suggestion back to our internal checkpatch.pl owners to
align with kernel's rules.
Regards,
Macpaul Lin
prev parent reply other threads:[~2019-12-05 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 6:01 [PATCH] usb: musb: replace all unsigned data type to unsigned int Macpaul Lin
2019-12-05 10:12 ` Russell King - ARM Linux admin
2019-12-05 14:52 ` Macpaul Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575557578.6727.2.camel@mtkswgap22 \
--to=macpaul.lin@mediatek.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox