Re: [PATCH v5 01/22] bootconfig: Add Extra Boot Config support

Steven Rostedt
2020-01-08T14:01:43Z

On Wed, 8 Jan 2020 14:17:00 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> > > +}
> > > +
> > > +/**
> > > + * xbc_node_is_key() - Test the node is a key node
> > > + * @node: An XBC node.
> > > + *
> > > + * Test the @node is a key node and return true if a key node, false if not.
> > > + */
> > > +static inline __init bool xbc_node_is_key(struct xbc_node *node)
> > > +{
> > > + return !(node->data & XBC_VALUE);
> > > +}
> > > +
>
> Maybe this is better use xbc_node_is_value()
>
> return !xbc_node_is_value();
>
> Right?

Agreed.

-- Steve

>