From: Martin Walch <walch.martin@web.de>
To: linux-kernel@vger.kernel.org
Subject: RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not
Date: Sat, 16 Mar 2013 20:35:59 +0100 [thread overview]
Message-ID: <1577953.rJTZvHtihu@tacticalops> (raw)
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
At drivers/staging/zcache/Kconfig:13 it says
config RAMSTER
bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE=y
depends on NET
# must ensure struct page is 8-byte aligned
select HAVE_ALIGNED_STRUCT_PAGE if !64_BIT
default n
However, there is no config section for the symbol 64_BIT, so !64_BIT will
always be evaluated to true, and therefore RAMSTER will always select
HAVE_ALIGNED_STRUCT_PAGE, disregarding any breakage.
64_BIT should probably say 64BIT which has corresponding config sections in
arch/{x86,ia64,mips,s390,tile,alpha,arm64,sparc,parisc,powerpc}/Kconfig and
arch/x86/um/Kconfig.
I do not know if there are any bad consequences about this, but I guess this
should be reviewed and fixed, probably by just removing the underscore from
64_BIT in drivers/staging/zcache/Kconfig.
Regards
Martin Walch
--
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2013-03-16 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 19:35 Martin Walch [this message]
2013-03-16 20:47 ` RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not Paul Bolle
2013-03-16 22:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577953.rJTZvHtihu@tacticalops \
--to=walch.martin@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox