Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller
2016-04-07T17:38:55Z

From: Joe Perches <joe@perches.com>
Date: Thu, 07 Apr 2016 09:31:17 -0700

> On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote:
>> Disable a debugging statement that has been left enabled
>>
>> Signed-off-by: David Howells <dhowells@redhat.com>
>> ---
>>
>>  net/rxrpc/ar-ack.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c
>> index 16d967075eaf..01a017a05f14 100644
>> --- a/net/rxrpc/ar-ack.c
>> +++ b/net/rxrpc/ar-ack.c
>> @@ -426,7 +426,7 @@ static void rxrpc_rotate_tx_window(struct rxrpc_call *call, u32 hard)
>>   int tail = call->acks_tail, old_tail;
>>   int win = CIRC_CNT(call->acks_head, tail, call->acks_winsz);
>>
>> - kenter("{%u,%u},%u", call->acks_hard, win, hard);
>> + _enter("{%u,%u},%u", call->acks_hard, win, hard);
>>
>>   ASSERTCMP(hard - call->acks_hard, <=, win);
>
> It might be better to remove kenter and _enter
> altogether and use function tracing instead.

Yeah this custom stuff is really inappropriate given the excellent
infrastructure we have these days...