From: Paul Cercueil <paul@crapouillou.net>
To: Maarten ter Huurne <maarten@treewalker.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
od@zcrc.me, linux-kernel@vger.kernel.org,
Mathieu Malaterre <malat@debian.org>,
Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v3] clocksource: Add driver for the Ingenic JZ47xx OST
Date: Wed, 15 Jan 2020 14:54:57 -0300 [thread overview]
Message-ID: <1579110897.3.0@crapouillou.net> (raw)
In-Reply-To: <2994787.aV6nBDHxoP@hyperion>
Le mer., janv. 15, 2020 at 18:48, Maarten ter Huurne
<maarten@treewalker.org> a écrit :
> On Wednesday, 15 January 2020 14:57:01 CET Paul Cercueil wrote:
>> Le mer., janv. 15, 2020 at 14:44, Daniel Lezcano
>> <daniel.lezcano@linaro.org> a écrit :
>> > Is the JZ47xx OST really a mfd needing a regmap? (Note regmap_read
>> > will take a lock).
>>
>> Yes, the TCU_REG_OST_TCSR register is shared with the clocks driver.
>
> The TCU_REG_OST_TCSR register is only used in the probe though.
>
> To get the counter value from TCU_REG_OST_CNTL/TCU_REG_OST_CNTH you
> could technically do it by reading the register directly, if
> performance
> concerns make it necessary to bypass the usual kernel infrastructure
> for
> dealing with shared registers.
In theory yes, in practice there's no easy way to do that (the
underlying mmio pointer is not obtainable from the regmap), and
besides, the lock is just a spinlock and not a mutex.
-Paul
next prev parent reply other threads:[~2020-01-15 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 15:06 [PATCH v3] clocksource: Add driver for the Ingenic JZ47xx OST Paul Cercueil
2020-01-15 13:44 ` Daniel Lezcano
2020-01-15 13:57 ` Paul Cercueil
2020-01-15 17:48 ` Maarten ter Huurne
2020-01-15 17:54 ` Paul Cercueil [this message]
2020-01-15 19:54 ` Thomas Gleixner
2020-01-15 20:58 ` Paul Cercueil
2020-01-15 21:50 ` Thomas Gleixner
2020-02-08 7:09 ` Daniel Lezcano
2020-02-08 13:23 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579110897.3.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=contact@artur-rojek.eu \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=malat@debian.org \
--cc=od@zcrc.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).