From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbbG0LCW (ORCPT ); Mon, 27 Jul 2015 07:02:22 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:54440 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbbG0LCU (ORCPT ); Mon, 27 Jul 2015 07:02:20 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-d5-55b60fb957f6 From: Bartlomiej Zolnierkiewicz To: Viresh Kumar Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] cpufreq-dt: add turbo modes support Date: Mon, 27 Jul 2015 13:01:43 +0200 Message-id: <15810554.2OjPyuYJBt@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20150727083754.GD31611@linux> References: <1436456621-29839-1-git-send-email-b.zolnierkie@samsung.com> <1436456621-29839-4-git-send-email-b.zolnierkie@samsung.com> <20150727083754.GD31611@linux> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t9jQd2d/NtCDY5NUrS4/uU5q8X/R69Z La79nsFm8fqFoUXvgqtsFv2PXzNbfD28gtHizcPNjBabHl9jtfjYc4/V4vKuOWwWn3uPMFrM OL+PyWLdxlvsFhdPuVocftPOatGxjNGibfUHVotVu/4wWmz86uEg4vH+Riu7x9/ZrcweO2fd ZffYtKqTzePOtT1sHpuX1Hv8O8bu0bdlFaPH9mvzmD0+b5IL4IrisklJzcksSy3St0vgymh9 uoitoIOz4nbzRKYGxiXsXYycHBICJhITjj9lhrDFJC7cW8/WxcjFISQwi1FiwoN5zBDOV0aJ na33WUCq2ASsJCa2r2LsYuTgEBHQknh5MxWkhlngOavE/Web2UBqhAXsJTr6X4NNZRFQlThw 5AlYnBeo/sqVSUwgtqiAl8T3Xw1gNZwC2hJPNy1igVi2glHi5fffrBANghI/Jt8DW8wsIC+x b/9UVghbS2L9zuNMExiB7kQom4WkbBaSsgWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLz czcxguPymdQOxoO73A8xCnAwKvHwXlDZGirEmlhWXJl7iFGCg1lJhPdxFFCINyWxsiq1KD++ qDQntfgQozQHi5I4r+yGzaFCAumJJanZqakFqUUwWSYOTqkGxjV/LwWllHV5HnNXlGYvDtA/ vsj0lPzOe0psmfG2nqK1DkcTes/HvZXx7ni2UelxgG5CXuV8k6QpP7bm33Q4yTe3oVJQivMC g22dRNNd0YUTE8Nvss+xmDbd6qJVyFSmpY/k7qlv279oTchPm7m+K56I5EdYXZOVS/9lGyB+ Pfdt9eXDOdY7lFiKMxINtZiLihMBWEjIsccCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, July 27, 2015 02:07:54 PM Viresh Kumar wrote: > On 09-07-15, 17:43, Bartlomiej Zolnierkiewicz wrote: > > diff --git a/include/linux/cpufreq-dt.h b/include/linux/cpufreq-dt.h > > index 0414009..483ca1b 100644 > > --- a/include/linux/cpufreq-dt.h > > +++ b/include/linux/cpufreq-dt.h > > @@ -17,6 +17,7 @@ struct cpufreq_dt_platform_data { > > * clock. > > */ > > bool independent_clocks; > > + bool boost_supported; > > }; > > I am planning to kill this structure soon, don't add anything to it. > We should be doing this based on DT. This change was in the original patch posted in April: https://lkml.org/lkml/2015/4/10/646 your review from a month ago didn't contain this request: https://lkml.org/lkml/2015/6/22/667 and now (after nearly 4 months) you are telling me that I should change this because you are planning to do some more changes in the future. Could we please keep it as it is for now and change it later (after independent_clocks configuration will get ported to use device tree)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics