Re: [PATCH v7 3/7] Bindings: nvmem: add bindings for JZ4780 efuse

Paul Cercueil
2020-02-28T14:41:05Z

Hi Nikolaus,

Le ven., févr. 28, 2020 at 14:58, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>
> This patch brings support for the JZ4780 efuse. Currently it only
> exposes
> a read only access to the entire 8K bits efuse memory.
>
> Tested-by: Mathieu Malaterre <malat@debian.org>
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> [converted to yaml]
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 49
> +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> new file mode 100644
> index 000000000000..ce6690c50a34
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ingenic JZ EFUSE driver bindings
> +
> +maintainers:
> + - PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
> +
> +allOf:
> + - $ref: "nvmem.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - ingenic,jz4780-efuse
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + # Handle for the ahb for the efuse.
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: ahb2

You still have clock-names here. You can remove it completely.

> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/jz4780-cgu.h>
> +
> + efuse@134100d0 {
> + compatible = "ingenic,jz4780-efuse";
> + reg = <0x134100d0 0x2c>;
> +
> + clocks = <&cgu JZ4780_CLK_AHB2>;
> + };
> +
> +...
> --
> 2.23.0
>