Re: [PATCH V4 15/17] cxl/pmem_region: Add sysfs attribute cxl region label updation/deletion

[Neeraj Kumar <s.neeraj@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

On 19/11/25 04:10PM, Dave Jiang wrote:
>
>
>On 11/19/25 12:52 AM, Neeraj Kumar wrote:
>> Using these attributes region label is added/deleted into LSA. These
>> attributes are called from userspace (ndctl) after region creation.
>>
>> Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com>
>> ---
>>  Documentation/ABI/testing/sysfs-bus-cxl | 22 ++++++
>>  drivers/cxl/core/pmem_region.c          | 93 ++++++++++++++++++++++++-
>>  drivers/cxl/cxl.h                       |  7 ++
>>  3 files changed, 121 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
>> index c80a1b5a03db..76d79c03dde4 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-cxl
>> +++ b/Documentation/ABI/testing/sysfs-bus-cxl
>> @@ -624,3 +624,25 @@ Description:
>>  		The count is persistent across power loss and wraps back to 0
>>  		upon overflow. If this file is not present, the device does not
>>  		have the necessary support for dirty tracking.
>> +
>> +
>> +What:		/sys/bus/cxl/devices/regionZ/pmem_regionZ/region_label_update
>> +Date:		Nov, 2025
>> +KernelVersion:	v6.19
>> +Contact:	linux-cxl@vger.kernel.org
>> +Description:
>> +		(RW) Write a boolean 'true' string value to this attribute to
>> +		update cxl region information into LSA as region label. It
>> +		uses nvdimm nd_region_label_update() to update cxl region
>> +		information saved during cxl region creation into LSA. This
>> +		attribute must be called at last during cxl region creation.
>
>Please consider:
>attribute must be written last during cxl region creation.
>
>No need to mention kernel specifics like function names. Just give general description of what the attribute does. Same for the next attribute below.
>
>Also, does this attribute needs to be readable? The documentation above does not explain the read attribute if so.
>
>DJ

Fixed it in V5


Regards,
Neeraj

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]