From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B34CC4332B for ; Fri, 20 Mar 2020 04:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5989C20732 for ; Fri, 20 Mar 2020 04:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbgCTE1C (ORCPT ); Fri, 20 Mar 2020 00:27:02 -0400 Received: from mga01.intel.com ([192.55.52.88]:30843 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbgCTE0w (ORCPT ); Fri, 20 Mar 2020 00:26:52 -0400 IronPort-SDR: V7NcWXWA3btcPTr5QazVqTGaYbUtWlUjvGe5W8efqMu20+zTLhILxi5VbsFZHfQNRIcZwWiVW0 PvsLP5VTXrkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 21:26:52 -0700 IronPort-SDR: cUDD6OwounXVP6wgeAIXq8ABX85BU+fXqD4Zy83cDwmTjd8GThv0y46dU8irmZ6D0c08wVbxmk pIBw/ThxCncg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,283,1580803200"; d="scan'208";a="234391241" Received: from jacob-builder.jf.intel.com ([10.7.199.155]) by orsmga007.jf.intel.com with ESMTP; 19 Mar 2020 21:26:51 -0700 From: Jacob Pan To: LKML , iommu@lists.linux-foundation.org, "Lu Baolu" , Joerg Roedel , David Woodhouse Cc: Raj Ashok , "Yi Liu" , Jacob Pan Subject: [PATCH 1/3] iommu/vt-d: Remove redundant IOTLB flush Date: Thu, 19 Mar 2020 21:32:29 -0700 Message-Id: <1584678751-43169-2-git-send-email-jacob.jun.pan@linux.intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1584678751-43169-1-git-send-email-jacob.jun.pan@linux.intel.com> References: <1584678751-43169-1-git-send-email-jacob.jun.pan@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IOTLB flush already included in the PASID tear down process. There is no need to flush again. Cc: Lu Baolu Signed-off-by: Jacob Pan --- drivers/iommu/intel-svm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c index 8f42d717d8d7..1483f1845762 100644 --- a/drivers/iommu/intel-svm.c +++ b/drivers/iommu/intel-svm.c @@ -268,10 +268,9 @@ static void intel_mm_release(struct mmu_notifier *mn, struct mm_struct *mm) * *has* to handle gracefully without affecting other processes. */ rcu_read_lock(); - list_for_each_entry_rcu(sdev, &svm->devs, list) { + list_for_each_entry_rcu(sdev, &svm->devs, list) intel_pasid_tear_down_entry(svm->iommu, sdev->dev, svm->pasid); - intel_flush_svm_range_dev(svm, sdev, 0, -1, 0); - } + rcu_read_unlock(); } @@ -731,7 +730,6 @@ int intel_svm_unbind_mm(struct device *dev, int pasid) * large and has to be physically contiguous. So it's * hard to be as defensive as we might like. */ intel_pasid_tear_down_entry(iommu, dev, svm->pasid); - intel_flush_svm_range_dev(svm, sdev, 0, -1, 0); kfree_rcu(sdev, rcu); if (list_empty(&svm->devs)) { -- 2.7.4