From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v3 0/3] block/diskstats: more accurate io_ticks and optimization
Date: Tue, 24 Mar 2020 09:39:38 +0300 [thread overview]
Message-ID: <158503038812.1955.7827988255138056389.stgit@buzz> (raw)
Simplified estimation for io_ticks introduced in patch
https://lore.kernel.org/linux-block/20181206164122.2166-5-snitzer@redhat.com/
could be very inaccurate for request longer than jiffy (i.e. any HDD)
There is at least one another report about this:
https://lore.kernel.org/linux-block/20200324031942.GA3060@ming.t460p/
See detail in comment for first patch.
v1: https://lore.kernel.org/lkml/155413438394.3201.15211440151043943989.stgit@buzz/
v2: https://lore.kernel.org/lkml/158314549775.1788.6529015932237292177.stgit@buzz/
v3:
* update documentation
* rebase to current linux-next
* fix compilation for CONFIG_SMP=n
---
Konstantin Khlebnikov (3):
block/diskstats: more accurate approximation of io_ticks for slow disks
block/diskstats: accumulate all per-cpu counters in one pass
block/diskstats: replace time_in_queue with sum of request times
Documentation/admin-guide/iostats.rst | 5 ++-
block/bio.c | 9 ++---
block/blk-core.c | 5 +--
block/genhd.c | 64 +++++++++++++++++++++++++--------
block/partition-generic.c | 39 ++++++++++++--------
include/linux/genhd.h | 14 +++++--
6 files changed, 90 insertions(+), 46 deletions(-)
--
Signature
next reply other threads:[~2020-03-24 6:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 6:39 Konstantin Khlebnikov [this message]
2020-03-24 6:39 ` [PATCH v3 1/3] block/diskstats: more accurate approximation of io_ticks for slow disks Konstantin Khlebnikov
2020-03-24 14:06 ` Ming Lei
2020-03-25 3:40 ` Ming Lei
2020-03-25 6:28 ` Konstantin Khlebnikov
2020-03-25 8:02 ` Konstantin Khlebnikov
2020-03-25 8:54 ` Ming Lei
2020-03-25 13:02 ` Konstantin Khlebnikov
2020-03-26 7:53 ` Ming Lei
2020-03-24 6:39 ` [PATCH v3 2/3] block/diskstats: accumulate all per-cpu counters in one pass Konstantin Khlebnikov
2020-03-24 6:39 ` [PATCH v3 3/3] block/diskstats: replace time_in_queue with sum of request times Konstantin Khlebnikov
2020-03-24 16:06 ` [PATCH v3 0/3] block/diskstats: more accurate io_ticks and optimization Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158503038812.1955.7827988255138056389.stgit@buzz \
--to=khlebnikov@yandex-team.ru \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox