Re: lockdep warning in urb.c:363 usb_submit_urb

Oliver Neukum
2020-03-23T15:36:25Z

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Am Montag, den 23.03.2020, 14:38 +0000 schrieb Qais Yousef:
> Hi
>
> I've hit the following lockdep warning when I trigger hibernate on arm64
> platform (Juno-r2)
>
>
> echo suspend > /sys/power/disk
> echo disk > /sys/power/state
>
> I only had a usb flash drive attached to it. Let me know if you need more info.

Hi,

that is not a lockdep issue, but the hub driver is not properly killing
its URB presumably. Yet, the driver looks correct to me. Please use
the additional patch and activate dynamic debugging for usbcore.

Regards
Oliver

[-- Attachment #2: 0001-usb-hub-additional-debugging.patch --]
[-- Type: text/x-patch, Size: 683 bytes --]

From 8357d9d7abe35d5e3684f5127fea6d2430011526 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Mon, 23 Mar 2020 16:34:35 +0100
Subject: [PATCH] usb: hub additional debugging

---
drivers/usb/core/hub.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 54cd8ef795ec..25530cf30381 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1629,6 +1629,7 @@ static int hub_configure(struct usb_hub *hub,
ret = -ENOMEM;
goto fail;
}
+ dev_dbg(hub_dev, "%p URB allocated \n");

usb_fill_int_urb(hub->urb, hdev, pipe, *hub->buffer, maxp, hub_irq,
hub, endpoint->bInterval);
--
2.16.4