Re: [PATCH 4/5] drm: msm: a6xx: Fix off by one error when setting GPU freq

Jordan Crouse
2020-03-31T16:44:16Z

On Tue, Mar 31, 2020 at 01:25:52PM +0530, Sharat Masetty wrote:
> This patch fixes an error in the for loop, thereby allowing search on
> the full list of possible GPU power levels.
>
> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>

Oh fun. This qualifies for drm-fixes. Can you pull this out of the stack and CC
stable?

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 489d9b6..81b8559 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -176,7 +176,7 @@ void a6xx_gmu_set_freq(struct msm_gpu *gpu, unsigned long freq)
> if (freq == gmu->freq)
> return;
>
> - for (perf_index = 0; perf_index < gmu->nr_gpu_freqs - 1; perf_index++)
> + for (perf_index = 0; perf_index < gmu->nr_gpu_freqs; perf_index++)
> if (freq == gmu->gpu_freqs[perf_index])
> break;
>
> --
> 2.7.4
>

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project