public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Giovanni Gherdovich <ggherdovich@suse.cz>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Doug Smythies <dsmythies@telus.net>
Subject: Re: [PATCH 0/2] cpufreq: intel_pstate: Run in the passive mode by default on systems without HWP
Date: Tue, 07 Apr 2020 17:35:27 +0200	[thread overview]
Message-ID: <1586273727.1721.20.camel@suse.cz> (raw)
In-Reply-To: <2016232.ihCVsphvri@kreacher>

On Sat, 2020-03-28 at 13:54 +0100, Rafael J. Wysocki wrote:
> Hi All,
> 
> These two patches modify the intel_pstate driver to run in the passive mode by
> default on systems without HWP (refer to the changelog of patch [2/2] for the
> motivation part).
> 
> Internal testing of the system performance in 5.6-rc indicates that the
> difference between the active mode with the powersave scaling algorithm and the
> passive mode with the schedutil governor should be negligible for the majority
> of users, so it should be safe to change the default behavior of the driver as
> per the above.
> 
> Patch [1/2] makes changes to select the schedutil governor and set it as the
> default one when intel_pstate is selected in Kconfig.
> 
> Patch [2/2] changes intel_pstate to start in the passive by default if HWP is
> not supported (or if it is disabled via the kernel command line).
> 
> Please refer to the patch changelogs for more information.
> 

Hello Rafael,

just to say that I'm very happy about this patch; I see it as a sensible
roll-out strategy for wide adoption of schedutil on x86, as it initially
applies to non-HWP only and not to the entire processor model range. As we get
more reports of its behavior on the field, we'll see when and how to move
forward from there.

I didn't reply last week as I was handling some bug reports for frequency
invariance on x86; one from LKML (Chris Wilson from Intel found that it
crashes when cpu0 is taken offline) and two more reported internally at
SUSE. Nothing major though, I am writing fixes for all those and will send
a bugfix series within the next few days.


Thanks!
Giovanni

      parent reply	other threads:[~2020-04-07 15:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-28 12:54 [PATCH 0/2] cpufreq: intel_pstate: Run in the passive mode by default on systems without HWP Rafael J. Wysocki
2020-03-28 12:57 ` [PATCH 1/2] cpufreq: intel_pstate: Select schedutil as the default governor Rafael J. Wysocki
2020-03-28 12:57 ` [PATCH 2/2] cpufreq: intel_pstate: Use passive mode by default without HWP Rafael J. Wysocki
2020-07-09 21:01   ` Doug Smythies
2020-07-13 12:16     ` Rafael J. Wysocki
2020-04-07 15:35 ` Giovanni Gherdovich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1586273727.1721.20.camel@suse.cz \
    --to=ggherdovich@suse.cz \
    --cc=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox