Re: [PATCH v8 1/5] dt-bindings: phy: Add binding for qcom,usb-snps-femto-v2

Vinod Koul
2020-05-06T04:17:39Z

On 05-05-20, 12:38, Wesley Cheng wrote:
>
>
> On 5/5/2020 6:34 AM, Rob Herring wrote:
> > On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote:
> >> This binding shows the descriptions and properties for the
> >> Synopsis Femto USB PHY V2 used on QCOM platforms.
> >>
> >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> >> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> >> ---
> >> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 77 ++++++++++++++++++++++
> >> 1 file changed, 77 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda18-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda33-supply' is a required property
> >
> > See https://patchwork.ozlabs.org/patch/1283143
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
> >
>
> Hi Rob,
>
> I updated the dt-schema version, and I can see the same error. Will fix
> and resubmit. I also realized that the dt_binding_check doesn't stop if

No, pls submit the fix against already applied patches and also give
credit to Rob by adding a "Reported-by: ..."

> errors are detected in the example DT checking phase, and that was
> probably why I missed this initially. I'll pass the DT_SCHEMA_FILES
> argument to my specific binding next time to help verify my file.
> Thanks again!
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

--
~Vinod