From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756350Ab1JQPwN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 Oct 2011 11:52:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63466 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753190Ab1JQPwJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 Oct 2011 11:52:09 -0400
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <alpine.LRH.2.00.1110151125280.24994@tundra.namei.org>
References: <alpine.LRH.2.00.1110151125280.24994@tundra.namei.org> <cover.1318598705.git.dmitry.kasatkin@intel.com> <92d93a9fe52e048a21d19732c31d80c9ec44de77.1318598705.git.dmitry.kasatkin@intel.com>
To: James Morris <jmorris@namei.org>
Cc: dhowells@redhat.com, Dmitry Kasatkin <dmitry.kasatkin@intel.com>,
        linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com,
        herbert@gondor.hengli.com.au
Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)
Date: Mon, 17 Oct 2011 16:50:51 +0100
Message-ID: <15891.1318866651@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

James Morris <jmorris@namei.org> wrote:

> > +MPI mpi_alloc(unsigned nlimbs)
> > +{
> > +	MPI a;
> > +
> > +	a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
> 
> Generally, typedef structs are frowned upon in the kernel.  I'd prefer to 
> see this (and any others) changed to a normal type.

In this case, however, it makes it easier to compare back to the original
code.

David