Re: [RFC PATCH 5/8] qaic: Implement data path

Greg KH
2020-05-14T15:56:49Z

On Thu, May 14, 2020 at 09:06:53AM -0600, Jeffrey Hugo wrote:
> On 5/14/2020 8:14 AM, Greg KH wrote:
> > On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote:
> > > +struct qaic_execute {
> > > + __u16 ver; /* struct version, must be 1 */
> >
> > No need for structures to be versioned. If you change something, then
> > add a new ioctl if you really needed it.
>
> Huh. We had thought the botching ioctls document advised having a version,
> but as I double check that document, it infact does not.
>
> Will remove.

Thanks, you can also remove the "reserved" variables as well as those
will not be needed either.

greg k-h