Re: [RFC PATCH 1/8] qaic: Add skeleton driver

Greg KH
2020-05-15T06:37:42Z

On Thu, May 14, 2020 at 06:43:06PM -0600, Jeffrey Hugo wrote:
> On 5/14/2020 8:07 AM, Jeffrey Hugo wrote:
> > +#define QAIC_NAME "Qualcomm Cloud AI 100"
> <snip>
> > +static struct pci_driver qaic_pci_driver = {
> > + .name = QAIC_NAME,
>
> A question about the community's preference here.
>
> Our driver name is very verbose due to the desire to have the proper
> "branding". However, I can see it being a bit obtuse, particularly in logs.
>
> Would the community prefer something more succinct here, such as "qaic"?

Make it the same a KBUILD_MODNAME and then no one can complain :)

thanks,

greg k-h