Re: [PATCH V3 1/9] pinctrl: imx: Support building SCU pinctrl driver as module

kernel test robot
2020-06-09T21:41:43Z

[-- Attachment #1: Type: text/plain, Size: 4288 bytes --]

Hi Anson,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Anson-Huang/Support-i-MX8-SoCs-pinctrl-drivers-built-as-module/20200609-223423
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: arm64-randconfig-r004-20200607 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

aarch64-linux-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init':
>> drivers/pinctrl/freescale/pinctrl-scu.c:43: undefined reference to `imx_scu_get_handle'
aarch64-linux-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu':
>> drivers/pinctrl/freescale/pinctrl-scu.c:62: undefined reference to `imx_scu_call_rpc'
aarch64-linux-ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu':
drivers/pinctrl/freescale/pinctrl-scu.c:100: undefined reference to `imx_scu_call_rpc'

vim +43 drivers/pinctrl/freescale/pinctrl-scu.c

b96eea718bf697 A.s. Dong 2018-10-30 40
b96eea718bf697 A.s. Dong 2018-10-30 41 int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
b96eea718bf697 A.s. Dong 2018-10-30 42 {
b96eea718bf697 A.s. Dong 2018-10-30 @43 return imx_scu_get_handle(&pinctrl_ipc_handle);
b96eea718bf697 A.s. Dong 2018-10-30 44 }
3c8d42d4fdbf10 Anson Huang 2020-06-09 45 EXPORT_SYMBOL_GPL(imx_pinctrl_sc_ipc_init);
b96eea718bf697 A.s. Dong 2018-10-30 46
b96eea718bf697 A.s. Dong 2018-10-30 47 int imx_pinconf_get_scu(struct pinctrl_dev *pctldev, unsigned pin_id,
b96eea718bf697 A.s. Dong 2018-10-30 48 unsigned long *config)
b96eea718bf697 A.s. Dong 2018-10-30 49 {
b96eea718bf697 A.s. Dong 2018-10-30 50 struct imx_sc_msg_req_pad_get msg;
b96eea718bf697 A.s. Dong 2018-10-30 51 struct imx_sc_msg_resp_pad_get *resp;
b96eea718bf697 A.s. Dong 2018-10-30 52 struct imx_sc_rpc_msg *hdr = &msg.hdr;
b96eea718bf697 A.s. Dong 2018-10-30 53 int ret;
b96eea718bf697 A.s. Dong 2018-10-30 54
b96eea718bf697 A.s. Dong 2018-10-30 55 hdr->ver = IMX_SC_RPC_VERSION;
b96eea718bf697 A.s. Dong 2018-10-30 56 hdr->svc = IMX_SC_RPC_SVC_PAD;
b96eea718bf697 A.s. Dong 2018-10-30 57 hdr->func = IMX_SC_PAD_FUNC_GET;
b96eea718bf697 A.s. Dong 2018-10-30 58 hdr->size = 2;
b96eea718bf697 A.s. Dong 2018-10-30 59
b96eea718bf697 A.s. Dong 2018-10-30 60 msg.pad = pin_id;
b96eea718bf697 A.s. Dong 2018-10-30 61
b96eea718bf697 A.s. Dong 2018-10-30 @62 ret = imx_scu_call_rpc(pinctrl_ipc_handle, &msg, true);
b96eea718bf697 A.s. Dong 2018-10-30 63 if (ret)
b96eea718bf697 A.s. Dong 2018-10-30 64 return ret;
b96eea718bf697 A.s. Dong 2018-10-30 65
b96eea718bf697 A.s. Dong 2018-10-30 66 resp = (struct imx_sc_msg_resp_pad_get *)&msg;
b96eea718bf697 A.s. Dong 2018-10-30 67 *config = resp->val;
b96eea718bf697 A.s. Dong 2018-10-30 68
b96eea718bf697 A.s. Dong 2018-10-30 69 return 0;
b96eea718bf697 A.s. Dong 2018-10-30 70 }
3c8d42d4fdbf10 Anson Huang 2020-06-09 71 EXPORT_SYMBOL_GPL(imx_pinconf_get_scu);
b96eea718bf697 A.s. Dong 2018-10-30 72

:::::: The code at line 43 was first introduced by commit
:::::: b96eea718bf697e4a490c2fabfb89995b9193c21 pinctrl: fsl: add scu based pinctrl support

:::::: TO: A.s. Dong <aisheng.dong@nxp.com>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39824 bytes --]