From: Roger Lu <roger.lu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Nicolas Boichat <drinkcat@google.com>,
Angus Lin <Angus.Lin@mediatek.com>, <linux-pm@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@kernel.org>, <linux-kernel@vger.kernel.org>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
YT Lee <yt.lee@mediatek.com>, Fan Chen <fan.chen@mediatek.com>,
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-mediatek@lists.infradead.org>,
HenryC Chen <HenryC.Chen@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Nishanth Menon <nm@ti.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 1/4] dt-bindings: power: avs: add mtk svs dt-bindings
Date: Wed, 10 Jun 2020 15:26:24 +0800 [thread overview]
Message-ID: <1591773984.14659.14.camel@mtksdaap41> (raw)
In-Reply-To: <20200609173636.GA1125574@bogus>
Dear Rob,
Thanks for the feedback.
On Tue, 2020-06-09 at 11:36 -0600, Rob Herring wrote:
> On Tue, 09 Jun 2020 18:45:31 +0800, Roger Lu wrote:
> > Document the binding for enabling mtk svs on MediaTek SoC.
> >
> > Signed-off-by: Roger Lu <roger.lu@mediatek.com>
> > ---
> > .../bindings/power/avs/mtk_svs.yaml | 141 ++++++++++++++++++
> > 1 file changed, 141 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/avs/mtk_svs.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/power/avs/mtk_svs.example.dts:22:18: fatal error: dt-bindings/power/mt8183-power.h: No such file or directory
> #include <dt-bindings/power/mt8183-power.h>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> scripts/Makefile.lib:312: recipe for target 'Documentation/devicetree/bindings/power/avs/mtk_svs.example.dt.yaml' failed
> make[1]: *** [Documentation/devicetree/bindings/power/avs/mtk_svs.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Makefile:1300: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1305800
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.
Oops, mt8183-power.h is added in below patch which is still under review
in patchwork. In order to have complete SVS description, mt8183-power.h
is added in mtk_svs.yaml.
Therefore, this issue will be fixed after patch including mt8183-power.h
is merged.
#dt-bindings/power/mt8183-power.h
https://patchwork.kernel.org/patch/11562521/
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-06-10 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 10:45 [PATCH v9 0/3] PM / AVS: SVS: Introduce SVS engine Roger Lu
2020-06-09 10:45 ` [PATCH v9 1/4] dt-bindings: power: avs: add mtk svs dt-bindings Roger Lu
2020-06-09 17:35 ` Rob Herring
2020-06-09 17:36 ` Rob Herring
2020-06-10 7:26 ` Roger Lu [this message]
2020-06-09 10:45 ` [PATCH v9 2/4] arm64: dts: mt8183: add svs device information Roger Lu
2020-06-09 10:45 ` [PATCH v9 3/4] PM / AVS: SVS: introduce SVS engine Roger Lu
2020-06-09 10:45 ` [PATCH v9 4/4] PM / AVS: SVS: add SVS debug commands Roger Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591773984.14659.14.camel@mtksdaap41 \
--to=roger.lu@mediatek.com \
--cc=Angus.Lin@mediatek.com \
--cc=Charles.Yang@mediatek.com \
--cc=HenryC.Chen@mediatek.com \
--cc=Xiaoqing.Liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=fan.chen@mediatek.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=yt.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox