From: Mugilraj D <dmugil2000@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Mugilraj D <dmugil2000@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Bakker <xc-racer2@live.ca>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: accel: Replace symbolic permissions with octal permissions
Date: Sat, 13 Jun 2020 13:49:01 +0530 [thread overview]
Message-ID: <1592036351-10166-1-git-send-email-dmugil2000@gmail.com> (raw)
Resolve following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.
Signed-off-by: Mugilraj D <dmugil2000@gmail.com>
---
drivers/iio/accel/bma180.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 265722e..b716347 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -531,14 +531,13 @@ static ssize_t bma180_show_scale_avail(struct device *dev,
}
static IIO_DEVICE_ATTR(in_accel_filter_low_pass_3db_frequency_available,
- S_IRUGO, bma180_show_filter_freq_avail, NULL, 0);
+ 0444, bma180_show_filter_freq_avail, NULL, 0);
static IIO_DEVICE_ATTR(in_accel_scale_available,
- S_IRUGO, bma180_show_scale_avail, NULL, 0);
+ 0444, bma180_show_scale_avail, NULL, 0);
static struct attribute *bma180_attributes[] = {
- &iio_dev_attr_in_accel_filter_low_pass_3db_frequency_available.
- dev_attr.attr,
+ &iio_dev_attr_in_accel_filter_low_pass_3db_frequency_available.dev_attr.attr,
&iio_dev_attr_in_accel_scale_available.dev_attr.attr,
NULL,
};
--
2.7.4
next reply other threads:[~2020-06-13 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 8:19 Mugilraj D [this message]
2020-06-14 13:27 ` [PATCH] iio: accel: Replace symbolic permissions with octal permissions Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592036351-10166-1-git-send-email-dmugil2000@gmail.com \
--to=dmugil2000@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox