From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: zzuedu2000@163.com, tj@kernel.org, lizefan@huawei.com,
hannes@cmpxchg.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Markus.Elfring@web.de, songmuchun@bytedance.com,
buddy.zhang@aliyun.com
Subject: Re: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set()
Date: Sun, 14 Jun 2020 11:10:08 -0700 [thread overview]
Message-ID: <1592158208.5303.27.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200614022833.2641-1-zzuedu2000@163.com>
On Sun, 2020-06-14 at 10:28 +0800, zzuedu2000@163.com wrote:
> From: Wei Fenghai <zzuedu2000@163.com>
>
> Combine two assignments for the variable ‘l’ into one statement.
The problem with this commit message isn't the description, we can all
see what the change does, it's the justification. Why is there any
reason to do this? My version of gcc does this as an optimization
anyway, so the patch doesn't change to the binary output and it's
arguable that having two statements instead of one makes the code
marginally more readable.
Regards,
James
next prev parent reply other threads:[~2020-06-14 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 2:28 [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set() zzuedu2000
2020-06-14 18:10 ` James Bottomley [this message]
2020-06-14 23:22 ` zzuedu2000
2020-06-15 1:11 ` Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592158208.5303.27.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Markus.Elfring@web.de \
--cc=buddy.zhang@aliyun.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=songmuchun@bytedance.com \
--cc=tj@kernel.org \
--cc=zzuedu2000@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox