From: Deepak Kumar Singh <deesin@codeaurora.org>
To: bjorn.andersson@linaro.org, clew@codeaurora.org,
mathieu.poirier@linaro.org
Cc: Deepak Kumar Singh <deesin@codeaurora.org>,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
linux-remoteproc@vger.kernel.org (open list:REMOTE PROCESSOR
MESSAGING (RPMSG) SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V7 4/4] rpmsg: glink: Expose rpmsg name attr for glink
Date: Wed, 24 Jun 2020 22:15:21 +0530 [thread overview]
Message-ID: <1593017121-7953-5-git-send-email-deesin@codeaurora.org> (raw)
In-Reply-To: <1593017121-7953-1-git-send-email-deesin@codeaurora.org>
From: Chris Lew <clew@codeaurora.org>
Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.
Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
drivers/rpmsg/qcom_glink_native.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 3a7f87c..0e8a28c0 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1574,6 +1574,26 @@ static void qcom_glink_cancel_rx_work(struct qcom_glink *glink)
kfree(dcmd);
}
+static ssize_t rpmsg_name_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ int ret = 0;
+ const char *name;
+
+ ret = of_property_read_string(dev->of_node, "label", &name);
+ if (ret < 0)
+ name = dev->of_node->name;
+
+ return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", name);
+}
+static DEVICE_ATTR_RO(rpmsg_name);
+
+static struct attribute *qcom_glink_attrs[] = {
+ &dev_attr_rpmsg_name.attr,
+ NULL
+};
+ATTRIBUTE_GROUPS(qcom_glink);
+
static void qcom_glink_device_release(struct device *dev)
{
struct rpmsg_device *rpdev = to_rpmsg_device(dev);
@@ -1638,6 +1658,12 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev,
idr_init(&glink->lcids);
idr_init(&glink->rcids);
+ glink->dev->groups = qcom_glink_groups;
+
+ ret = device_add_groups(dev, qcom_glink_groups);
+ if (ret)
+ dev_err(dev, "failed to add groups\n");
+
ret = of_property_read_string(dev->of_node, "label", &glink->name);
if (ret < 0)
glink->name = dev->of_node->name;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2020-06-24 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593017121-7953-1-git-send-email-deesin@codeaurora.org>
2020-06-24 16:45 ` [PATCH V7 1/4] rpmsg: glink: Use complete_all for open states Deepak Kumar Singh
2020-06-24 16:45 ` [PATCH V7 2/4] rpmsg: Guard against null endpoint ops in destroy Deepak Kumar Singh
2020-08-07 7:59 ` Greg KH
2020-08-08 0:33 ` Chris Lew
2020-08-08 5:55 ` Greg KH
2020-06-24 16:45 ` [PATCH V7 3/4] rpmsg: glink: Add support for rpmsg glink chrdev Deepak Kumar Singh
2020-06-24 16:45 ` Deepak Kumar Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593017121-7953-5-git-send-email-deesin@codeaurora.org \
--to=deesin@codeaurora.org \
--cc=agross@kernel.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox