From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference
Date: Tue, 30 Jun 2020 15:28:59 +0800 [thread overview]
Message-ID: <1593502139.23885.5.camel@mhfsdcap03> (raw)
In-Reply-To: <99fc1f6e-7907-6723-612a-8b68ffa871e5@web.de>
On Mon, 2020-06-29 at 10:00 +0200, Markus Elfring wrote:
> > Some pointers are dereferenced before successful checks.
>
> I suggest to reconsider and improve the change description.
>
> * Would a null pointer dereference be possible only with the variables “mep”
> and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?
>
> * How do you think about to adjust any more variable initialisations?
Yes, I'll do it if need, thanks
>
> * Will it become helpful to add the tag “Fixes” to the commit message?
Maybe needn't
>
> Regards,
> Markus
next prev parent reply other threads:[~2020-06-30 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593410434-19406-1-git-send-email-chunfeng.yun@mediatek.com>
2020-06-29 7:30 ` [PATCH 1/2] usb: mtu3: disable USB2 LPM Markus Elfring
2020-06-29 8:10 ` Greg Kroah-Hartman
2020-06-29 7:37 ` Peter Chen
2020-06-30 7:03 ` Chunfeng Yun
2020-06-29 8:15 ` Markus Elfring
[not found] ` <1593410434-19406-2-git-send-email-chunfeng.yun@mediatek.com>
2020-06-29 8:00 ` [PATCH 2/2] usb: mtu3: fix NULL pointer dereference Markus Elfring
2020-06-29 8:10 ` Greg Kroah-Hartman
2020-06-30 7:28 ` Chunfeng Yun [this message]
2020-06-29 16:19 ` Searching for initialisation of variables by function calls before null pointer checks Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593502139.23885.5.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=Markus.Elfring@web.de \
--cc=colin.king@canonical.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox