Re: [PATCH v3 5/8] ASoC: qcom: lpass-platform: Replace card->dev with component->dev

Srinivas Kandagatla
2020-07-09T09:27:06Z

On 08/07/2020 06:08, Rohit kumar wrote:
> From: Ajit Pandey <ajitp@codeaurora.org>
>
> We are allocating dma memory for component->dev but trying to mmap
> such memory for substream->pcm->card->dev. Replace device argument
> in mmap with component->dev to fix this.
>
> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---
> sound/soc/qcom/lpass-platform.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
> index 445ca193..f9424cc 100644
> --- a/sound/soc/qcom/lpass-platform.c
> +++ b/sound/soc/qcom/lpass-platform.c
> @@ -472,9 +472,8 @@ static int lpass_platform_pcmops_mmap(struct snd_soc_component *component,
> {
> struct snd_pcm_runtime *runtime = substream->runtime;
>
> - return dma_mmap_coherent(substream->pcm->card->dev, vma,
> - runtime->dma_area, runtime->dma_addr,
> - runtime->dma_bytes);
> + return dma_mmap_coherent(component->dev, vma, runtime->dma_area,
> + runtime->dma_addr, runtime->dma_bytes);
> }
>
> static irqreturn_t lpass_dma_interrupt_handler(
>