public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, mhiramat@kernel.org,
	Andi Kleen <andi@firstfloor.org>, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 0/4] perf-probe: Fix GNU IFUNC probe issue etc.
Date: Thu,  9 Jul 2020 17:06:51 +0900	[thread overview]
Message-ID: <159428201109.56570.3802208017109058146.stgit@devnote2> (raw)

Hi,

Here are patches to fix some issues of probing on GNU IFUNC, duplicated
symbols, and memory leak, which were reported by Andi.

Andi reported that some issues on probing memcpy function in glibc,
which was related to GNU IFUNC (indirect function). As I described
in the patch [4/4], it is hard to support probing on the functions
which are selected by GNU indirect function because those are chosen
at runtime. I think we need a user-mode helper in uprobes to find which
one is chosen at runtime. (Oleg, Srikar, would you have any idea?)

While cleaning up the patches, I also found a memory leak problem
so fixed it ([3/4]).

Thank you,

---

Masami Hiramatsu (4):
      perf-probe: Avoid setting probes on same address on same event
      perf-probe: Fix wrong variable warning when the probe point is not found
      perf-probe: Fix memory leakage when the probe point is not found
      perf-probe: Warn if the target function is GNU Indirect function


 tools/perf/util/probe-event.c  |   14 ++++++++++++++
 tools/perf/util/probe-finder.c |    5 ++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>

             reply	other threads:[~2020-07-09  8:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09  8:06 Masami Hiramatsu [this message]
2020-07-09  8:07 ` [PATCH 1/4] perf-probe: Avoid setting probes on same address on same event Masami Hiramatsu
2020-07-10 11:18   ` Srikar Dronamraju
2020-07-10 12:14     ` Masami Hiramatsu
2020-07-09  8:07 ` [PATCH 2/4] perf-probe: Fix wrong variable warning when the probe point is not found Masami Hiramatsu
2020-07-09 14:37   ` Andi Kleen
2020-07-10 11:16   ` Srikar Dronamraju
2020-07-09  8:07 ` [PATCH 3/4] perf-probe: Fix memory leakage " Masami Hiramatsu
2020-07-10 11:16   ` Srikar Dronamraju
2020-07-09  8:07 ` [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function Masami Hiramatsu
2020-07-09 14:36   ` Andi Kleen
2020-07-10  3:30     ` Masami Hiramatsu
2020-07-10 11:55       ` Arnaldo Carvalho de Melo
2020-07-10 12:56         ` Masami Hiramatsu
2020-07-10 11:15   ` Srikar Dronamraju
2020-07-10 12:14     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159428201109.56570.3802208017109058146.stgit@devnote2 \
    --to=mhiramat@kernel.org \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox