Re: [PATCH v4 4/4] clk: qcom: lpass: Add support for LPASS clock controller for SC7180

Taniya Das
2020-07-24T16:07:26Z

Hi Stephen,

Thanks for the review.

On 7/21/2020 1:18 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-07-14 23:36:50)
>> diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpasscorecc-sc7180.c

>> +static struct clk_alpha_pll lpass_lpaaudio_dig_pll = {
>> + .offset = 0x1000,
>> + .vco_table = fabia_vco,
>> + .num_vco = ARRAY_SIZE(fabia_vco),
>> + .regs = clk_alpha_pll_regs_offset[CLK_ALPHA_PLL_TYPE_FABIA],
>> + .clkr = {
>> + .hw.init = &(struct clk_init_data){
>> + .name = "lpass_lpaaudio_dig_pll",
>> + .parent_data = &(const struct clk_parent_data){
>> + .fw_name = "bi_tcxo",
>> + .name = "bi_tcxo",
>
> We don't need .name if we have .fw_name and this is a new binding/device.
>

My bad, will cleanup in the next patch.

>> + },
>> + .num_parents = 1,
>> + .ops = &clk_alpha_pll_fabia_ops,
>> + },
>> + },
>> +};
>> +

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--